Merge development
This commit is contained in:
		| @@ -1,4 +1,17 @@ | ||||
| [ | ||||
|     { | ||||
|         "version": "1.0.1-rc.3", | ||||
|         "changes": [ | ||||
|             { | ||||
|                 "note": "Dependencies updated" | ||||
|             }, | ||||
|             { | ||||
|                 "pr": 914, | ||||
|                 "note": "Update ecSignOrderHashAsync to return the signature as a string for immediate use in contracts" | ||||
|             } | ||||
|         ], | ||||
|         "timestamp": 1534210131 | ||||
|     }, | ||||
|     { | ||||
|         "version": "1.0.1-rc.2", | ||||
|         "changes": [ | ||||
|   | ||||
| @@ -5,6 +5,11 @@ Edit the package's CHANGELOG.json file only. | ||||
|  | ||||
| CHANGELOG | ||||
|  | ||||
| ## v1.0.1-rc.3 - _August 13, 2018_ | ||||
|  | ||||
|     * Dependencies updated | ||||
|     * Update ecSignOrderHashAsync to return the signature as a string for immediate use in contracts (#914) | ||||
|  | ||||
| ## v1.0.1-rc.2 - _July 26, 2018_ | ||||
|  | ||||
|     * Fixed bug caused by importing non-existent dep | ||||
| @@ -17,11 +22,11 @@ CHANGELOG | ||||
|  | ||||
|     * Dependencies updated | ||||
|  | ||||
| ## v1.0.0-rc.2 - _July 20, 2018_ | ||||
| ## v1.0.0-rc.2 - _July 19, 2018_ | ||||
|  | ||||
|     * Remove `zeroEx.assetData`  and instead re-export it's static functions directly off `ZeroEx` | ||||
|  | ||||
| ## v1.0.0-rc.1 - _July 20, 2018_ | ||||
| ## v1.0.0-rc.1 - _July 19, 2018_ | ||||
|  | ||||
|     * Remove tokenRegistry wrapper (#863) | ||||
|     * Rename `zeroEx.token` to `zeroEx.erc20Token`, and add `zeroEx.erc721Token` (#863) | ||||
| @@ -61,7 +66,7 @@ CHANGELOG | ||||
|     * Renamed createOrderStateWatcher to createOrderWatcherAsync since it is now async (#579) | ||||
|     * Renamed ZeroExError to ContractWrappersErrors since they now lives in the @0xproject/contract-wrappers subpackage (#579) | ||||
|  | ||||
| ## v0.37.2 - _May 5, 2018_ | ||||
| ## v0.37.2 - _May 4, 2018_ | ||||
|  | ||||
|     * Dependencies updated | ||||
|  | ||||
|   | ||||
| @@ -1,6 +1,6 @@ | ||||
| { | ||||
|     "name": "0x.js", | ||||
|     "version": "1.0.1-rc.2", | ||||
|     "version": "1.0.1-rc.3", | ||||
|     "engines": { | ||||
|         "node": ">=6.12" | ||||
|     }, | ||||
| @@ -50,9 +50,11 @@ | ||||
|     }, | ||||
|     "license": "Apache-2.0", | ||||
|     "devDependencies": { | ||||
|         "@0xproject/dev-utils": "^1.0.3", | ||||
|         "@0xproject/migrations": "^1.0.3", | ||||
|         "@0xproject/tslint-config": "^1.0.4", | ||||
|         "@0xproject/abi-gen": "^1.0.5", | ||||
|         "@0xproject/dev-utils": "^1.0.4", | ||||
|         "@0xproject/migrations": "^1.0.4", | ||||
|         "@0xproject/monorepo-scripts": "^1.0.5", | ||||
|         "@0xproject/tslint-config": "^1.0.5", | ||||
|         "@types/lodash": "4.14.104", | ||||
|         "@types/mocha": "^2.2.42", | ||||
|         "@types/node": "^8.0.53", | ||||
| @@ -65,7 +67,7 @@ | ||||
|         "dirty-chai": "^2.0.1", | ||||
|         "json-loader": "^0.5.4", | ||||
|         "make-promises-safe": "^1.1.0", | ||||
|         "mocha": "^4.0.1", | ||||
|         "mocha": "^4.1.0", | ||||
|         "npm-run-all": "^4.1.2", | ||||
|         "nyc": "^11.0.1", | ||||
|         "opn-cli": "^3.1.0", | ||||
| @@ -74,23 +76,23 @@ | ||||
|         "source-map-support": "^0.5.0", | ||||
|         "tslint": "5.11.0", | ||||
|         "typedoc": "0xProject/typedoc", | ||||
|         "typescript": "2.7.1", | ||||
|         "typescript": "2.9.2", | ||||
|         "webpack": "^3.1.0" | ||||
|     }, | ||||
|     "dependencies": { | ||||
|         "@0xproject/assert": "^1.0.4", | ||||
|         "@0xproject/base-contract": "^1.0.4", | ||||
|         "@0xproject/contract-wrappers": "^1.0.1-rc.2", | ||||
|         "@0xproject/order-utils": "^1.0.1-rc.2", | ||||
|         "@0xproject/sol-compiler": "^1.0.4", | ||||
|         "@0xproject/subproviders": "^1.0.4", | ||||
|         "@0xproject/types": "^1.0.1-rc.3", | ||||
|         "@0xproject/typescript-typings": "^1.0.3", | ||||
|         "@0xproject/utils": "^1.0.4", | ||||
|         "@0xproject/web3-wrapper": "^1.1.2", | ||||
|         "ethereum-types": "^1.0.3", | ||||
|         "@0xproject/assert": "^1.0.5", | ||||
|         "@0xproject/base-contract": "^2.0.0-rc.1", | ||||
|         "@0xproject/contract-wrappers": "^1.0.1-rc.3", | ||||
|         "@0xproject/order-utils": "^1.0.1-rc.3", | ||||
|         "@0xproject/sol-compiler": "^1.0.5", | ||||
|         "@0xproject/subproviders": "^1.0.5", | ||||
|         "@0xproject/types": "^1.0.1-rc.4", | ||||
|         "@0xproject/typescript-typings": "^1.0.4", | ||||
|         "@0xproject/utils": "^1.0.5", | ||||
|         "@0xproject/web3-wrapper": "^1.2.0", | ||||
|         "ethereum-types": "^1.0.4", | ||||
|         "ethers": "3.0.22", | ||||
|         "lodash": "^4.17.4" | ||||
|         "lodash": "^4.17.5" | ||||
|     }, | ||||
|     "publishConfig": { | ||||
|         "access": "public" | ||||
|   | ||||
| @@ -9,17 +9,11 @@ import { | ||||
|     EtherTokenWrapper, | ||||
|     ExchangeWrapper, | ||||
| } from '@0xproject/contract-wrappers'; | ||||
| import { | ||||
|     assetDataUtils, | ||||
|     generatePseudoRandomSalt, | ||||
|     signatureUtils, | ||||
|     MessagePrefixOpts, | ||||
|     orderHashUtils, | ||||
| } from '@0xproject/order-utils'; | ||||
| import { assetDataUtils, generatePseudoRandomSalt, signatureUtils, orderHashUtils } from '@0xproject/order-utils'; | ||||
| // HACK: Since we export assetDataUtils from ZeroEx and it has AssetProxyId, ERC20AssetData and ERC721AssetData | ||||
| // in it's public interface, we need to import these types here. | ||||
| // tslint:disable-next-line:no-unused-variable | ||||
| import { AssetProxyId, ECSignature, ERC20AssetData, ERC721AssetData, Order, SignedOrder } from '@0xproject/types'; | ||||
| import { AssetProxyId, ERC20AssetData, ERC721AssetData, Order, SignedOrder, SignerType } from '@0xproject/types'; | ||||
| import { BigNumber } from '@0xproject/utils'; | ||||
| import { Web3Wrapper } from '@0xproject/web3-wrapper'; | ||||
| import { Provider, TransactionReceiptWithDecodedLogs } from 'ethereum-types'; | ||||
| @@ -237,19 +231,21 @@ export class ZeroEx { | ||||
|      * @param   orderHash       Hex encoded orderHash to sign. | ||||
|      * @param   signerAddress   The hex encoded Ethereum address you wish to sign it with. This address | ||||
|      *          must be available via the Provider supplied to 0x.js. | ||||
|      * @param   messagePrefixOpts  Options regarding the desired prefix and whether to add it before calling `eth_sign` | ||||
|      * @return  An object containing the Elliptic curve signature parameters generated by signing the orderHash. | ||||
|      * @param   signerType the signer type that will perform the `eth_sign` operation. E.g Default, Metamask, Ledger or Trezor. | ||||
|      *          Some implementations exhibit different behaviour. Default will assume a spec compliant eth_sign implementation. | ||||
|      *          This parameter is defaulted to `SignerType.Default`. | ||||
|      * @return  A hex encoded string of the Elliptic curve signature parameters generated by signing the orderHash and signature type. | ||||
|      */ | ||||
|     public async ecSignOrderHashAsync( | ||||
|         orderHash: string, | ||||
|         signerAddress: string, | ||||
|         messagePrefixOpts: MessagePrefixOpts, | ||||
|     ): Promise<ECSignature> { | ||||
|         signerType: SignerType = SignerType.Default, | ||||
|     ): Promise<string> { | ||||
|         const signature = await signatureUtils.ecSignOrderHashAsync( | ||||
|             this._contractWrappers.getProvider(), | ||||
|             orderHash, | ||||
|             signerAddress, | ||||
|             messagePrefixOpts, | ||||
|             signerType, | ||||
|         ); | ||||
|         return signature; | ||||
|     } | ||||
|   | ||||
| @@ -48,8 +48,6 @@ export { | ||||
|     OrderInfo, | ||||
| } from '@0xproject/contract-wrappers'; | ||||
|  | ||||
| export { MessagePrefixType, MessagePrefixOpts } from '@0xproject/order-utils'; | ||||
|  | ||||
| export { | ||||
|     ExchangeContractErrs, | ||||
|     Order, | ||||
|   | ||||
| @@ -48,10 +48,11 @@ describe('ZeroEx library', () => { | ||||
|         const ethSignSignature = | ||||
|             '0x1B61a3ed31b43c8780e905a260a35faefcc527be7516aa11c0256729b5b351bc3340349190569279751135161d22529dc25add4f6069af05be04cacbda2ace225403'; | ||||
|         const address = '0x5409ed021d9299bf6814279a6a1411a7e866a631'; | ||||
|         const bytes32Zeros = '0x0000000000000000000000000000000000000000000000000000000000000000'; | ||||
|         it("should return false if the data doesn't pertain to the signature & address", async () => { | ||||
|             return expect((zeroEx.exchange as any).isValidSignatureAsync('0x0', address, ethSignSignature)).to.become( | ||||
|                 false, | ||||
|             ); | ||||
|             return expect( | ||||
|                 (zeroEx.exchange as any).isValidSignatureAsync(bytes32Zeros, address, ethSignSignature), | ||||
|             ).to.become(false); | ||||
|         }); | ||||
|         it("should return false if the address doesn't pertain to the signature & data", async () => { | ||||
|             const validUnrelatedAddress = '0x8b0292b11a196601ed2ce54b665cafeca0347d42'; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user