ZeroEx: TransformERC20, TokenSpender (#2545)
* `@0x/contracts-utils`: Convert more 0.6 contracts * `@0x/contracts-erc20`: Add solidity 0.6 contracts. * `@0x/utils`: Add new `ZeroExRevertErrors` revert types * `@0x/contracts-zero-ex`: Introduce the `TransformERC20` feature. * `@0x/subproviders`: Update ganache-core. `@0x/web3-wrapper`: Update ganache-core. * `@0x/contracts-zero-ex`: Make `TokenSpender`'s puppet contract a distinct contract type and rename `getTokenSpenderPuppet()` to `getAllowanceTarget()` * `@0x/zero-ex`: Rebase and use "slot" instead of "offset" language in storage buckets. * `@0x/web3-wrapper`: Add `getAccountNonceAsync()` to `Web3Wrapper` * `@0x/contracts-zero-ex`: Revamp TransformERC20. * `@0x/contracts-zero-ex`: Remove `payable` from `IERC20Transformer.transform()` and disable hex capitalization linter rule because of prettier conflicts. * `@0x/contracts-zero-ex`: Use `immutable` owner in `Puppet` instead of `Ownable`. * `@x/utils`: Address review feedback. * `@0x/contracts-zero-ex`: Address review feedback. * `@0x/contracts-utils`: Address review feedback. * `@0x/contracts-zero-ex`: Return deployment nonce in `transform()`. * `@0x/contracts-zero-ex`: Finish returning deployment nonce in `transform()`. * `@0x/contracts-zero-ex`: Fix doc-gen bug. * `@0x/contracts-zero-ex`: Address review comments. * `@0x/utils`: Add `NegativeTransformERC20OutputERror` * `@0x/contracts-zero-ex`: Revert if the taker's output amount decreases. Co-authored-by: Lawrence Forman <me@merklejerk.com>
This commit is contained in:
Lawrence Forman
GitHub
165
contracts/zero-ex/test/full_migration_test.ts
Normal file
165
contracts/zero-ex/test/full_migration_test.ts
Normal file
@@ -0,0 +1,165 @@
|
||||
import { BaseContract } from '@0x/base-contract';
|
||||
import { blockchainTests, constants, expect, randomAddress } from '@0x/contracts-test-utils';
|
||||
import { BigNumber, hexUtils, ZeroExRevertErrors } from '@0x/utils';
|
||||
import { DataItem, MethodAbi } from 'ethereum-types';
|
||||
import * as _ from 'lodash';
|
||||
|
||||
import { artifacts } from './artifacts';
|
||||
import { abis } from './utils/abis';
|
||||
import { deployFullFeaturesAsync, FullFeatures, toFeatureAdddresses } from './utils/migration';
|
||||
import {
|
||||
AllowanceTargetContract,
|
||||
IOwnableContract,
|
||||
ITokenSpenderContract,
|
||||
ITransformERC20Contract,
|
||||
TestFullMigrationContract,
|
||||
ZeroExContract,
|
||||
} from './wrappers';
|
||||
|
||||
const { NULL_ADDRESS } = constants;
|
||||
|
||||
blockchainTests.resets('Full migration', env => {
|
||||
let owner: string;
|
||||
let zeroEx: ZeroExContract;
|
||||
let features: FullFeatures;
|
||||
let migrator: TestFullMigrationContract;
|
||||
|
||||
before(async () => {
|
||||
[owner] = await env.getAccountAddressesAsync();
|
||||
features = await deployFullFeaturesAsync(env.provider, env.txDefaults);
|
||||
migrator = await TestFullMigrationContract.deployFrom0xArtifactAsync(
|
||||
artifacts.TestFullMigration,
|
||||
env.provider,
|
||||
env.txDefaults,
|
||||
artifacts,
|
||||
env.txDefaults.from as string,
|
||||
);
|
||||
const deployCall = migrator.deploy(owner, toFeatureAdddresses(features));
|
||||
zeroEx = new ZeroExContract(await deployCall.callAsync(), env.provider, env.txDefaults);
|
||||
await deployCall.awaitTransactionSuccessAsync();
|
||||
});
|
||||
|
||||
it('ZeroEx has the correct owner', async () => {
|
||||
const ownable = new IOwnableContract(zeroEx.address, env.provider, env.txDefaults);
|
||||
const actualOwner = await ownable.owner().callAsync();
|
||||
expect(actualOwner).to.eq(owner);
|
||||
});
|
||||
|
||||
it('FullMigration contract self-destructs', async () => {
|
||||
const dieRecipient = await migrator.dieRecipient().callAsync();
|
||||
expect(dieRecipient).to.eq(owner);
|
||||
});
|
||||
|
||||
it('Non-deployer cannot call deploy()', async () => {
|
||||
const notDeployer = randomAddress();
|
||||
const tx = migrator.deploy(owner, toFeatureAdddresses(features)).callAsync({ from: notDeployer });
|
||||
return expect(tx).to.revertWith('FullMigration/INVALID_SENDER');
|
||||
});
|
||||
|
||||
const FEATURE_FNS = {
|
||||
TokenSpender: {
|
||||
contractType: ITokenSpenderContract,
|
||||
fns: ['_spendERC20Tokens'],
|
||||
},
|
||||
TransformERC20: {
|
||||
contractType: ITransformERC20Contract,
|
||||
fns: ['transformERC20', '_transformERC20', 'createTransformWallet', 'getTransformWallet'],
|
||||
},
|
||||
};
|
||||
|
||||
function createFakeInputs(inputs: DataItem[] | DataItem): any | any[] {
|
||||
if ((inputs as DataItem[]).length !== undefined) {
|
||||
return (inputs as DataItem[]).map(i => createFakeInputs(i));
|
||||
}
|
||||
const item = inputs as DataItem;
|
||||
// TODO(dorothy-zbornak): Support fixed-length arrays.
|
||||
if (/\[]$/.test(item.type)) {
|
||||
return _.times(_.random(0, 8), () =>
|
||||
createFakeInputs({
|
||||
...item,
|
||||
type: item.type.substring(0, item.type.length - 2),
|
||||
}),
|
||||
);
|
||||
}
|
||||
if (/^tuple$/.test(item.type)) {
|
||||
const tuple = {} as any;
|
||||
for (const comp of item.components as DataItem[]) {
|
||||
tuple[comp.name] = createFakeInputs(comp);
|
||||
}
|
||||
return tuple;
|
||||
}
|
||||
if (item.type === 'address') {
|
||||
return randomAddress();
|
||||
}
|
||||
if (item.type === 'byte') {
|
||||
return hexUtils.random(1);
|
||||
}
|
||||
if (/^bytes$/.test(item.type)) {
|
||||
return hexUtils.random(_.random(0, 128));
|
||||
}
|
||||
if (/^bytes\d+$/.test(item.type)) {
|
||||
return hexUtils.random(parseInt(/\d+$/.exec(item.type)![0], 10));
|
||||
}
|
||||
if (/^uint\d+$/.test(item.type)) {
|
||||
return new BigNumber(hexUtils.random(parseInt(/\d+$/.exec(item.type)![0], 10) / 8));
|
||||
}
|
||||
if (/^int\d+$/.test(item.type)) {
|
||||
return new BigNumber(hexUtils.random(parseInt(/\d+$/.exec(item.type)![0], 10) / 8))
|
||||
.div(2)
|
||||
.times(_.sample([-1, 1])!);
|
||||
}
|
||||
throw new Error(`Unhandled input type: '${item.type}'`);
|
||||
}
|
||||
|
||||
for (const [featureName, featureInfo] of Object.entries(FEATURE_FNS)) {
|
||||
describe(`${featureName} feature`, () => {
|
||||
let contract: BaseContract & { getSelector(name: string): string };
|
||||
|
||||
before(async () => {
|
||||
contract = new featureInfo.contractType(zeroEx.address, env.provider, env.txDefaults, abis);
|
||||
});
|
||||
|
||||
for (const fn of featureInfo.fns) {
|
||||
it(`${fn} is registered`, async () => {
|
||||
const selector = contract.getSelector(fn);
|
||||
const impl = await zeroEx.getFunctionImplementation(selector).callAsync();
|
||||
expect(impl).to.not.eq(NULL_ADDRESS);
|
||||
});
|
||||
|
||||
if (fn.startsWith('_')) {
|
||||
it(`${fn} cannot be called from outside`, async () => {
|
||||
const method = contract.abi.find(
|
||||
d => d.type === 'function' && (d as MethodAbi).name === fn,
|
||||
) as MethodAbi;
|
||||
const inputs = createFakeInputs(method.inputs);
|
||||
const tx = (contract as any)[fn](...inputs).callAsync();
|
||||
return expect(tx).to.revertWith(
|
||||
new ZeroExRevertErrors.Common.OnlyCallableBySelfError(env.txDefaults.from),
|
||||
);
|
||||
});
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
describe("TokenSpender's allowance target", () => {
|
||||
let allowanceTarget: AllowanceTargetContract;
|
||||
|
||||
before(async () => {
|
||||
const contract = new ITokenSpenderContract(zeroEx.address, env.provider, env.txDefaults);
|
||||
allowanceTarget = new AllowanceTargetContract(
|
||||
await contract.getAllowanceTarget().callAsync(),
|
||||
env.provider,
|
||||
env.txDefaults,
|
||||
);
|
||||
});
|
||||
|
||||
it('is owned by owner', async () => {
|
||||
return expect(allowanceTarget.owner().callAsync()).to.become(owner);
|
||||
});
|
||||
|
||||
it('Proxy is authorized', async () => {
|
||||
return expect(allowanceTarget.authorized(zeroEx.address).callAsync()).to.become(true);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user