crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improve schemas by enforcing that amounts that must be whole numbers (e.g Order asset amounts) no longer allow decimal numbers

Browse Source
This commit is contained in:
Fabio Berger
2018-10-21 19:24:19 +02:00
parent b9dccf9da3
commit 632d7b6fc1
8 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/json-schemas/schemas/order_cancel_schema.json
View File

@@ -4,7 +4,7 @@
"items": { "items": {
"properties": { "properties": {
"order": { "$ref": "/orderSchema" }, "order": { "$ref": "/orderSchema" },
"takerTokenCancelAmount": { "$ref": "/numberSchema" } "takerTokenCancelAmount": { "$ref": "/wholeNumberSchema" }
}, },
"required": ["order", "takerTokenCancelAmount"], "required": ["order", "takerTokenCancelAmount"],
"type": "object" "type": "object"

2
packages/json-schemas/schemas/order_fill_or_kill_requests_schema.json
View File

@@ -4,7 +4,7 @@
"items": { "items": {
"properties": { "properties": {
"signedOrder": { "$ref": "/signedOrderSchema" }, "signedOrder": { "$ref": "/signedOrderSchema" },
"fillTakerAmount": { "$ref": "/numberSchema" } "fillTakerAmount": { "$ref": "/wholeNumberSchema" }
}, },
"required": ["signedOrder", "fillTakerAmount"], "required": ["signedOrder", "fillTakerAmount"],
"type": "object" "type": "object"

2
packages/json-schemas/schemas/order_fill_requests_schema.json
View File

@@ -4,7 +4,7 @@
"items": { "items": {
"properties": { "properties": {
"signedOrder": { "$ref": "/signedOrderSchema" }, "signedOrder": { "$ref": "/signedOrderSchema" },
"takerTokenFillAmount": { "$ref": "/numberSchema" } "takerTokenFillAmount": { "$ref": "/wholeNumberSchema" }
}, },
"required": ["signedOrder", "takerTokenFillAmount"], "required": ["signedOrder", "takerTokenFillAmount"],
"type": "object" "type": "object"

12
packages/json-schemas/schemas/order_schema.json
View File

@@ -3,17 +3,17 @@
"properties": { "properties": {
"makerAddress": { "$ref": "/addressSchema" }, "makerAddress": { "$ref": "/addressSchema" },
"takerAddress": { "$ref": "/addressSchema" }, "takerAddress": { "$ref": "/addressSchema" },
"makerFee": { "$ref": "/numberSchema" }, "makerFee": { "$ref": "/wholeNumberSchema" },
"takerFee": { "$ref": "/numberSchema" }, "takerFee": { "$ref": "/wholeNumberSchema" },
"senderAddress": { "$ref": "/addressSchema" }, "senderAddress": { "$ref": "/addressSchema" },
"makerAssetAmount": { "$ref": "/numberSchema" }, "makerAssetAmount": { "$ref": "/wholeNumberSchema" },
"takerAssetAmount": { "$ref": "/numberSchema" }, "takerAssetAmount": { "$ref": "/wholeNumberSchema" },
"makerAssetData": { "$ref": "/hexSchema" }, "makerAssetData": { "$ref": "/hexSchema" },
"takerAssetData": { "$ref": "/hexSchema" }, "takerAssetData": { "$ref": "/hexSchema" },
"salt": { "$ref": "/numberSchema" }, "salt": { "$ref": "/wholeNumberSchema" },
"exchangeAddress": { "$ref": "/addressSchema" }, "exchangeAddress": { "$ref": "/addressSchema" },
"feeRecipientAddress": { "$ref": "/addressSchema" }, "feeRecipientAddress": { "$ref": "/addressSchema" },
"expirationTimeSeconds": { "$ref": "/numberSchema" } "expirationTimeSeconds": { "$ref": "/wholeNumberSchema" }
}, },
"required": [ "required": [
"makerAddress", "makerAddress",

4
packages/json-schemas/schemas/relayer_api_asset_data_trade_info_schema.json
View File

@@ -3,8 +3,8 @@
"type": "object", "type": "object",
"properties": { "properties": {
"assetData": { "$ref": "/hexSchema" }, "assetData": { "$ref": "/hexSchema" },
"minAmount": { "$ref": "/numberSchema" }, "minAmount": { "$ref": "/wholeNumberSchema" },
"maxAmount": { "$ref": "/numberSchema" }, "maxAmount": { "$ref": "/wholeNumberSchema" },
"precision": { "type": "number" } "precision": { "type": "number" }
}, },
"required": ["assetData"] "required": ["assetData"]

6
packages/json-schemas/schemas/relayer_api_order_config_payload_schema.json
View File

@@ -4,12 +4,12 @@
"properties": { "properties": {
"makerAddress": { "$ref": "/addressSchema" }, "makerAddress": { "$ref": "/addressSchema" },
"takerAddress": { "$ref": "/addressSchema" }, "takerAddress": { "$ref": "/addressSchema" },
"makerAssetAmount": { "$ref": "/numberSchema" }, "makerAssetAmount": { "$ref": "/wholeNumberSchema" },
"takerAssetAmount": { "$ref": "/numberSchema" }, "takerAssetAmount": { "$ref": "/wholeNumberSchema" },
"makerAssetData": { "$ref": "/hexSchema" }, "makerAssetData": { "$ref": "/hexSchema" },
"takerAssetData": { "$ref": "/hexSchema" }, "takerAssetData": { "$ref": "/hexSchema" },
"exchangeAddress": { "$ref": "/addressSchema" }, "exchangeAddress": { "$ref": "/addressSchema" },
"expirationTimeSeconds": { "$ref": "/numberSchema" } "expirationTimeSeconds": { "$ref": "/wholeNumberSchema" }
}, },
"required": [ "required": [
"makerAddress", "makerAddress",

4
packages/json-schemas/schemas/relayer_api_order_config_response_schema.json
View File

@@ -2,8 +2,8 @@
"id": "/relayerApiOrderConfigResponseSchema", "id": "/relayerApiOrderConfigResponseSchema",
"type": "object", "type": "object",
"properties": { "properties": {
"makerFee": { "$ref": "/numberSchema" }, "makerFee": { "$ref": "/wholeNumberSchema" },
"takerFee": { "$ref": "/numberSchema" }, "takerFee": { "$ref": "/wholeNumberSchema" },
"feeRecipientAddress": { "$ref": "/addressSchema" }, "feeRecipientAddress": { "$ref": "/addressSchema" },
"senderAddress": { "$ref": "/addressSchema" } "senderAddress": { "$ref": "/addressSchema" }
}, },

2
packages/json-schemas/schemas/zero_ex_transaction_schema.json
View File

@@ -3,7 +3,7 @@
"properties": { "properties": {
"data": { "$ref": "/hexSchema" }, "data": { "$ref": "/hexSchema" },
"signerAddress": { "$ref": "/addressSchema" }, "signerAddress": { "$ref": "/addressSchema" },
"salt": { "$ref": "/numberSchema" } "salt": { "$ref": "/wholeNumberSchema" }
}, },
"required": ["data", "salt", "signerAddress"], "required": ["data", "salt", "signerAddress"],
"type": "object" "type": "object"