crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename method for clarity

Browse Source
This commit is contained in:
Fabio Berger
2018-03-20 21:41:21 +00:00
parent 4f76bb2a12
commit 647bc5a63e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/0x.js/src/0x.ts
View File

@@ -260,7 +260,7 @@ export class ZeroEx {
msgHashHex = ethUtil.bufferToHex(msgHashBuff); msgHashHex = ethUtil.bufferToHex(msgHashBuff);
} }
const signature = await this._web3Wrapper.signTransactionAsync(normalizedSignerAddress, msgHashHex); const signature = await this._web3Wrapper.signMessageAsync(normalizedSignerAddress, msgHashHex);
// HACK: There is no consensus on whether the signatureHex string should be formatted as // HACK: There is no consensus on whether the signatureHex string should be formatted as
// v + r + s OR r + s + v, and different clients (even different versions of the same client) // v + r + s OR r + s + v, and different clients (even different versions of the same client)

2
packages/web3-wrapper/src/index.ts
View File

@@ -70,7 +70,7 @@ export class Web3Wrapper {
const codeIsEmpty = /^0x0{0,40}$/i.test(code); const codeIsEmpty = /^0x0{0,40}$/i.test(code);
return !codeIsEmpty; return !codeIsEmpty;
} }
public async signTransactionAsync(address: string, message: string): Promise<string> { public async signMessageAsync(address: string, message: string): Promise<string> {
const signData = await promisify<string>(this._web3.eth.sign)(address, message); const signData = await promisify<string>(this._web3.eth.sign)(address, message);
return signData; return signData;
} }