Merge pull request #938 from 0xProject/sol-cov-fixes

Sol cov fixes
2018-08-13 16:40:46 -04:00
parent 083319786f 9d3c287918
commit 7340338626
10 changed files with 162 additions and 22 deletions
--- a/packages/json-schemas/CHANGELOG.json
+++ b/packages/json-schemas/CHANGELOG.json
@@ -2,6 +2,10 @@
    {
        "version": "1.0.1-rc.4",
        "changes": [
+            {
+                "note": "Allow for additional properties in txData schema",
+                "pr": 938
+            },
            {
                "note": "Change hexSchema to match `0x`",
                "pr": 937
--- a/packages/json-schemas/schemas/tx_data_schema.ts
+++ b/packages/json-schemas/schemas/tx_data_schema.ts
@@ -29,5 +29,4 @@ export const txDataSchema = {
    },
    required: ['from'],
    type: 'object',
-    additionalProperties: false,
 };
--- a/packages/json-schemas/test/schema_test.ts
+++ b/packages/json-schemas/test/schema_test.ts
@@ -849,10 +849,6 @@ describe('Schema', () => {
                {
                    gas: new BigNumber(42),
                },
-                {
-                    from: NULL_ADDRESS,
-                    unknownProp: 'here',
-                },
                {},
                [],
                new BigNumber(1),