crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused listeners

Browse Source
This commit is contained in:
Fabio Berger
2018-10-19 17:09:13 +01:00
parent 16ba01cd2e
commit 90ba8e0e8d
2 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/react-docs/src/components/doc_reference.tsx
View File

@@ -52,12 +52,6 @@ export interface DocReferenceProps {
export interface DocReferenceState {} export interface DocReferenceState {}
export class DocReference extends React.Component<DocReferenceProps, DocReferenceState> { export class DocReference extends React.Component<DocReferenceProps, DocReferenceState> {
public componentDidMount(): void {
window.addEventListener('hashchange', this._onHashChanged.bind(this), false);
}
public componentWillUnmount(): void {
window.removeEventListener('hashchange', this._onHashChanged.bind(this), false);
}
public componentDidUpdate(prevProps: DocReferenceProps, _prevState: DocReferenceState): void { public componentDidUpdate(prevProps: DocReferenceProps, _prevState: DocReferenceState): void {
if (!_.isEqual(prevProps.docAgnosticFormat, this.props.docAgnosticFormat)) { if (!_.isEqual(prevProps.docAgnosticFormat, this.props.docAgnosticFormat)) {
const hash = window.location.hash.slice(1); const hash = window.location.hash.slice(1);
@@ -323,8 +317,4 @@ export class DocReference extends React.Component<DocReferenceProps, DocReferenc
/> />
); );
} }
private _onHashChanged(_event: any): void {
const hash = window.location.hash.slice(1);
sharedUtils.scrollToHash(hash, sharedConstants.SCROLL_CONTAINER_ID);
}
} }

8
packages/website/ts/pages/wiki/wiki.tsx
View File

@@ -49,9 +49,6 @@ export class Wiki extends React.Component<WikiProps, WikiState> {
isHoveringSidebar: false, isHoveringSidebar: false,
}; };
} }
public componentDidMount(): void {
window.addEventListener('hashchange', this._onHashChanged.bind(this), false);
}
public componentWillMount(): void { public componentWillMount(): void {
// tslint:disable-next-line:no-floating-promises // tslint:disable-next-line:no-floating-promises
this._fetchArticlesBySectionAsync(); this._fetchArticlesBySectionAsync();
@@ -59,7 +56,6 @@ export class Wiki extends React.Component<WikiProps, WikiState> {
public componentWillUnmount(): void { public componentWillUnmount(): void {
this._isUnmounted = true; this._isUnmounted = true;
clearTimeout(this._wikiBackoffTimeoutId); clearTimeout(this._wikiBackoffTimeoutId);
window.removeEventListener('hashchange', this._onHashChanged.bind(this), false);
} }
public render(): React.ReactNode { public render(): React.ReactNode {
const sectionNameToLinks = _.isUndefined(this.state.articlesBySection) const sectionNameToLinks = _.isUndefined(this.state.articlesBySection)
@@ -198,8 +194,4 @@ export class Wiki extends React.Component<WikiProps, WikiState> {
} }
return sectionNameToLinks; return sectionNameToLinks;
} }
private _onHashChanged(_event: any): void {
const hash = window.location.hash.slice(1);
sharedUtils.scrollToHash(hash, sharedConstants.SCROLL_CONTAINER_ID);
}
} }