Correct inconsistencies in JSON schema names

In both ref ID's and file names.

.prettierignore

@@ -27,3 +27,6 @@ lib
 package.json
 scripts/postpublish_utils.js
 packages/sol-cov/test/fixtures/artifacts
+.pytest_cache
+.mypy_cache
+.tox

packages/json-schemas/schemas/asset_pairs_request_opts_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/AssetPairsRequestOpts",
+    "id": "/AssetPairsRequestOptsSchema",
     "type": "object",
     "properties": {
         "assetDataA": { "$ref": "/hexSchema" },

packages/json-schemas/schemas/call_data_schema.json

@@ -4,13 +4,13 @@
         "from": { "$ref": "/addressSchema" },
         "to": { "$ref": "/addressSchema" },
         "value": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "gas": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "gasPrice": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "data": {
             "type": "string",

packages/json-schemas/schemas/ec_signature_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/ECSignature",
+    "id": "/ecSignatureSchema",
     "properties": {
         "v": {
             "type": "number",

packages/json-schemas/schemas/js_number_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/jsNumber",
+    "id": "/jsNumberSchema",
     "type": "number",
     "minimum": 0
 }

packages/json-schemas/schemas/order_config_request_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/OrderConfigRequest",
+    "id": "/OrderConfigRequestSchema",
     "type": "object",
     "properties": {
         "makerAddress": { "$ref": "/addressSchema" },

packages/json-schemas/schemas/orderbook_request_schema.json

@@ -1,9 +1,9 @@
 {
-    "id": "/OrderBookRequest",
+    "id": "/OrderbookRequestSchema",
     "type": "object",
     "properties": {
         "baseAssetData": { "$ref": "/hexSchema" },
         "quoteAssetData": { "$ref": "/hexSchema" }
     },
     "required": ["baseAssetData", "quoteAssetData"]
-}
+}

packages/json-schemas/schemas/orders_request_opts_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/OrdersRequestOpts",
+    "id": "/OrdersRequestOptsSchema",
     "type": "object",
     "properties": {
         "makerAssetProxyId": { "$ref": "/hexSchema" },

packages/json-schemas/schemas/paged_request_opts_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/PagedRequestOpts",
+    "id": "/PagedRequestOptsSchema",
     "type": "object",
     "properties": {
         "page": { "type": "number" },

packages/json-schemas/schemas/request_opts_schema.json

@@ -1,5 +1,5 @@
 {
-    "id": "/RequestOpts",
+    "id": "/RequestOptsSchema",
     "type": "object",
     "properties": {
         "networkId": { "type": "number" }

packages/json-schemas/schemas/tx_data_schema.json

@@ -4,13 +4,13 @@
         "from": { "$ref": "/addressSchema" },
         "to": { "$ref": "/addressSchema" },
         "value": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "gas": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "gasPrice": {
-            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumber" }]
+            "oneOf": [{ "$ref": "/numberSchema" }, { "$ref": "/jsNumberSchema" }]
         },
         "data": {
             "type": "string",

packages/json-schemas/src/schemas.ts

@@ -8,7 +8,7 @@ import * as ecSignatureSchema from '../schemas/ec_signature_schema.json';
 import * as eip712TypedDataSchema from '../schemas/eip712_typed_data_schema.json';
 import * as hexSchema from '../schemas/hex_schema.json';
 import * as indexFilterValuesSchema from '../schemas/index_filter_values_schema.json';
-import * as jsNumber from '../schemas/js_number.json';
+import * as jsNumber from '../schemas/js_number_schema.json';
 import * as numberSchema from '../schemas/number_schema.json';
 import * as orderCancellationRequestsSchema from '../schemas/order_cancel_schema.json';
 import * as orderConfigRequestSchema from '../schemas/order_config_request_schema.json';

packages/json-schemas/tsconfig.json

@@ -40,7 +40,7 @@
         "./schemas/relayer_api_orders_schema.json",
         "./schemas/signed_orders_schema.json",
         "./schemas/token_schema.json",
-        "./schemas/js_number.json",
+        "./schemas/js_number_schema.json",
         "./schemas/zero_ex_transaction_schema.json",
         "./schemas/tx_data_schema.json",
         "./schemas/index_filter_values_schema.json",

python-packages/json_schemas/src/zero_ex/json_schemas/__init__.py

@@ -17,23 +17,7 @@ class _LocalRefResolver(jsonschema.RefResolver):
         jsonschema.RefResolver.__init__(self, "", "")
 
     @staticmethod
-    def _ref_to_file(ref: str) -> str:
+    def resolve_from_url(url: str) -> str:
-        """Translate a JSON schema ref to its corresponding file name.
-
-        >>> _LocalRefResolver._ref_to_file("/addressSchema")
-        'address_schema.json'
-        """
-        _ref = ref.lstrip("/")
-
-        # handle weird special cases
-        _ref = _ref.replace("ECSignature", "EcSignature")
-        if _ref.endswith("Schema"):
-            # strip off the Schema suffix
-            _ref = _ref[:-6]
-
-        return f"{snakecase(_ref)}_schema.json"
-
-    def resolve_from_url(self, url: str) -> str:
         """Resolve the given URL.
 
         :param url: a string representing the URL of the JSON schema to fetch.
@@ -45,7 +29,7 @@ class _LocalRefResolver(jsonschema.RefResolver):
         return json.loads(
             resource_string(
                 "zero_ex.json_schemas",
-                f"schemas/{_LocalRefResolver._ref_to_file(ref)}",
+                f"schemas/{snakecase(ref.lstrip('/'))}.json",
             )
         )
 
@@ -68,7 +52,7 @@ def assert_valid(data: Mapping, schema_id: str) -> None:
 
     >>> assert_valid(
     ...     {'v': 27, 'r': '0x'+'f'*64, 's': '0x'+'f'*64},
-    ...     '/ECSignature',
+    ...     '/ecSignatureSchema',
     ... )
     """
     # noqa