address CR feedback

This commit is contained in:
fragosti
2018-07-06 11:23:41 -07:00
parent 97809a03eb
commit afbc4989d5
2 changed files with 4 additions and 3 deletions

View File

@@ -805,12 +805,12 @@ export class Blockchain {
if (!_.isUndefined(this._watchGasPriceIntervalId)) { if (!_.isUndefined(this._watchGasPriceIntervalId)) {
return; // we are already watching return; // we are already watching
} }
const oneMinuteInMs = 60000;
// tslint:disable-next-line:no-floating-promises // tslint:disable-next-line:no-floating-promises
this._updateDefaultGasPriceAsync(); this._updateDefaultGasPriceAsync();
this._watchGasPriceIntervalId = intervalUtils.setAsyncExcludingInterval( this._watchGasPriceIntervalId = intervalUtils.setAsyncExcludingInterval(
this._updateDefaultGasPriceAsync.bind(this), this._updateDefaultGasPriceAsync.bind(this),
// 1 minute oneMinuteInMs,
60000,
(err: Error) => { (err: Error) => {
logUtils.log(`Watching gas price failed: ${err.stack}`); logUtils.log(`Watching gas price failed: ${err.stack}`);
this._stopWatchingGasPrice(); this._stopWatchingGasPrice();

View File

@@ -68,6 +68,7 @@ class PlainPortalOnboardingFlow extends React.Component<PortalOnboardingFlowProp
} }
} }
public render(): React.ReactNode { public render(): React.ReactNode {
const browserType = utils.getBrowserType();
return ( return (
<OnboardingFlow <OnboardingFlow
steps={this._getSteps()} steps={this._getSteps()}
@@ -78,7 +79,7 @@ class PlainPortalOnboardingFlow extends React.Component<PortalOnboardingFlowProp
disableOverlay={this.props.screenWidth === ScreenWidths.Sm} disableOverlay={this.props.screenWidth === ScreenWidths.Sm}
isMobile={this.props.screenWidth === ScreenWidths.Sm} isMobile={this.props.screenWidth === ScreenWidths.Sm}
// This is necessary to ensure onboarding stays open once the user unlocks metamask and clicks away // This is necessary to ensure onboarding stays open once the user unlocks metamask and clicks away
disableCloseOnClickOutside={utils.getBrowserType() === BrowserType.Firefox} disableCloseOnClickOutside={browserType === BrowserType.Firefox || browserType === BrowserType.Opera}
/> />
); );
} }