crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disallow address zero in Ownable

Browse Source
This commit is contained in:
Alex Towle
2019-07-30 12:43:59 -07:00
parent 92a4556956
commit b4a3218b13
5 changed files with 37 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
contracts/utils/test/ownable.ts
View File

@@ -42,12 +42,10 @@ describe('Ownable', () => {
});
describe('transferOwnership', () => {
it('should not transfer ownership if the specified new owner is the zero address', async () => {
expect(
ownable.transferOwnership.sendTransactionAsync(constants.NULL_ADDRESS, { from: owner }),
).to.be.fulfilled('');
const updatedOwner = await ownable.owner.callAsync();
expect(updatedOwner).to.be.eq(owner);
it('should revert if the specified new owner is the zero address', async () => {
const expectedError = new OwnableRevertErrors.TransferOwnerToZeroError();
const tx = ownable.transferOwnership.sendTransactionAsync(constants.NULL_ADDRESS, { from: owner });
return expect(tx).to.revertWith(expectedError);
});
it('should transfer ownership if the specified new owner is not the zero address', async () => {