crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Publish (#296)

Browse Source 
- @0x/contracts-integrations@2.7.60
 - @0x/asset-swapper@16.23.0

Co-authored-by: Github Actions <github-actions@github.com>
This commit is contained in:
Lawrence Forman
2021-07-29 10:54:37 -04:00
committed by GitHub
parent b358559421
commit c360f8d8fd
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/asset-swapper/CHANGELOG.json
View File

@@ -1,4 +1,13 @@
[ [
{
"version": "16.23.1",
"changes": [
{
"note": "Fix fill amount rounding error when covnerting fills to orders.",
"pr": 296
}
]
},
{ {
"version": "16.23.0", "version": "16.23.0",
"changes": [ "changes": [

4
packages/asset-swapper/src/utils/market_operation_utils/orders.ts
View File

@@ -480,9 +480,9 @@ export const BRIDGE_ENCODERS: {
function getFillTokenAmounts(fill: CollapsedFill, side: MarketOperation): [BigNumber, BigNumber] { function getFillTokenAmounts(fill: CollapsedFill, side: MarketOperation): [BigNumber, BigNumber] {
return [ return [
// Maker asset amount. // Maker asset amount.
side === MarketOperation.Sell ? fill.output : fill.input, side === MarketOperation.Sell ? fill.output.integerValue(BigNumber.ROUND_DOWN) : fill.input,
// Taker asset amount. // Taker asset amount.
side === MarketOperation.Sell ? fill.input : fill.output, side === MarketOperation.Sell ? fill.input : fill.output.integerValue(BigNumber.ROUND_UP),
]; ];
} }