crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/order-utils: Consolidate FillOrKill errors into IncompleteFillError.

Browse Source
This commit is contained in:
Lawrence Forman
2019-08-20 12:42:08 -04:00
parent 43f38d02ad
commit c659477358
1 changed files with 11 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
packages/order-utils/src/exchange_revert_errors.ts
View File

@@ -38,6 +38,12 @@ export enum TransactionErrorCode {
Expired, Expired,
} }
export enum IncompleteFillErrorCode {
IncompleteMarketBuyOrders,
IncompleteMarketSellOrders,
IncompleteFillOrder,
}
export class BatchMatchOrdersError extends RevertError { export class BatchMatchOrdersError extends RevertError {
constructor(error?: BatchMatchOrdersErrorCodes) { constructor(error?: BatchMatchOrdersErrorCodes) {
super('BatchMatchOrdersError', 'BatchMatchOrdersError(uint8 error)', { error }); super('BatchMatchOrdersError', 'BatchMatchOrdersError(uint8 error)', { error });
@@ -208,34 +214,15 @@ export class TransactionExecutionError extends RevertError {
} }
export class IncompleteFillError extends RevertError { export class IncompleteFillError extends RevertError {
constructor(takerAssetFillAmount?: BigNumber, orderHash?: string) { constructor(error?: IncompleteFillErrorCode, expectedAssetFillAmount?: BigNumber, actualAssetFillAmount?: BigNumber) {
super('IncompleteFillError', 'IncompleteFillError(uint256 takerAssetFillAmount, bytes32 orderHash)', { super('IncompleteFillError', 'IncompleteFillError(uint8 error, uint256 expectedAssetFillAmount, uint256 actualAssetFillAmount)', {
takerAssetFillAmount, error,
orderHash, expectedAssetFillAmount,
actualAssetFillAmount,
}); });
} }
} }
export class IncompleteMarketSellError extends RevertError {
constructor(takerAssetFillAmount?: BigNumber, orderHashes?: string[]) {
super(
'IncompleteMarketSellError',
'IncompleteMarketSellError(uint256 takerAssetFillAmount, bytes32[] orderHashes)',
{ takerAssetFillAmount, orderHashes },
);
}
}
export class IncompleteMarketBuyError extends RevertError {
constructor(makerAssetFillAmount?: BigNumber, orderHashes?: string[]) {
super(
'IncompleteMarketBuyError',
'IncompleteMarketBuyError(uint256 makerAssetFillAmount, bytes32[] orderHashes)',
{ makerAssetFillAmount, orderHashes },
);
}
}
const types = [ const types = [
BatchMatchOrdersError, BatchMatchOrdersError,
OrderStatusError, OrderStatusError,
@@ -256,8 +243,6 @@ const types = [
TransactionSignatureError, TransactionSignatureError,
TransactionExecutionError, TransactionExecutionError,
IncompleteFillError, IncompleteFillError,
IncompleteMarketSellError,
IncompleteMarketBuyError,
]; ];
// Register the types we've defined. // Register the types we've defined.