Don't reassign the parameter

2017-11-22 14:00:16 -06:00
parent c453099f6b
commit d20926e150
1 changed files with 3 additions and 3 deletions
--- a/packages/0x.js/test/utils/order_factory.ts
+++ b/packages/0x.js/test/utils/order_factory.ts
@@ -15,11 +15,11 @@ export const orderFactory = {
        takerTokenAddress: string,
        exchangeContractAddress: string,
        feeRecipient: string,
-        expirationUnixTimestampSec?: BigNumber): Promise<SignedOrder> {
+        expirationUnixTimestampSecIfExists?: BigNumber): Promise<SignedOrder> {
        const defaultExpirationUnixTimestampSec = new BigNumber(2524604400); // Close to infinite
-        expirationUnixTimestampSec = _.isUndefined(expirationUnixTimestampSec) ?
+        const expirationUnixTimestampSec = _.isUndefined(expirationUnixTimestampSecIfExists) ?
            defaultExpirationUnixTimestampSec :
-            expirationUnixTimestampSec;
+            expirationUnixTimestampSecIfExists;
        const order = {
            maker,
            taker,