Merge pull request #2212 from 0xProject/refactor/no-domain-in-order

Remove domain from Order and remove OrderWithoutDomain type
2019-09-27 14:04:18 -07:00
parent f5ad65bb8a a9ecf7f1f3
commit d21f978def
47 changed files with 232 additions and 249 deletions
--- a/packages/asset-swapper/test/exchange_swap_quote_consumer_test.ts
+++ b/packages/asset-swapper/test/exchange_swap_quote_consumer_test.ts
@@ -82,10 +82,8 @@ describe('ExchangeSwapQuoteConsumer', () => {
            takerAssetData,
            makerFeeAssetData: assetDataUtils.encodeERC20AssetData(contractAddresses.zrxToken),
            takerFeeAssetData: assetDataUtils.encodeERC20AssetData(contractAddresses.zrxToken),
-            domain: {
-                verifyingContract: contractAddresses.exchange,
-                chainId: networkId,
-            },
+            exchangeAddress: contractAddresses.exchange,
+            chainId: networkId,
        };
        const privateKey = devConstants.TESTRPC_PRIVATE_KEYS[userAddresses.indexOf(makerAddress)];
        orderFactory = new OrderFactory(privateKey, defaultOrderParams);