crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed remaining instances of implicit bool casts to explicit lodash calls

Browse Source
This commit is contained in:
Greg Hysen
2018-11-27 13:35:39 -08:00
parent 1f693ea121
commit ffb8b0a619
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/utils/src/abi_encoder/abstract_data_types/types/pointer.ts
View File

@@ -21,7 +21,7 @@ export abstract class Pointer extends DataType {
} }
public generateCalldataBlock(value: any, parentBlock?: CalldataBlock): CalldataBlocks.Pointer { public generateCalldataBlock(value: any, parentBlock?: CalldataBlock): CalldataBlocks.Pointer {
if (!parentBlock) { if (_.isUndefined(parentBlock)) {
throw new Error(`DependentDataType requires a parent block to generate its block`); throw new Error(`DependentDataType requires a parent block to generate its block`);
} }
const destinationBlock = this._destination.generateCalldataBlock(value, parentBlock); const destinationBlock = this._destination.generateCalldataBlock(value, parentBlock);

4
packages/utils/src/abi_encoder/calldata/blocks/set.ts
View File

@@ -14,7 +14,7 @@ export class Set extends CalldataBlock {
public getRawData(): Buffer { public getRawData(): Buffer {
const rawDataComponents: Buffer[] = []; const rawDataComponents: Buffer[] = [];
if (this._header) { if (!_.isUndefined(this._header)) {
rawDataComponents.push(this._header); rawDataComponents.push(this._header);
} }
_.each(this._members, (member: CalldataBlock) => { _.each(this._members, (member: CalldataBlock) => {
@@ -35,7 +35,7 @@ export class Set extends CalldataBlock {
} }
public toBuffer(): Buffer { public toBuffer(): Buffer {
if (this._header) { if (!_.isUndefined(this._header)) {
return this._header; return this._header;
} }
return new Buffer(''); return new Buffer('');

5
packages/utils/src/abi_encoder/evm_data_type_factory.ts
View File

@@ -2,6 +2,7 @@
/* tslint:disable max-classes-per-file */ /* tslint:disable max-classes-per-file */
/* tslint:disable no-construct */ /* tslint:disable no-construct */
import { DataItem, MethodAbi } from 'ethereum-types'; import { DataItem, MethodAbi } from 'ethereum-types';
import * as _ from 'lodash';
import { DataType, DataTypeFactory } from './abstract_data_types'; import { DataType, DataTypeFactory } from './abstract_data_types';
import * as Impl from './evm_data_types'; import * as Impl from './evm_data_types';
@@ -105,9 +106,9 @@ export class EvmDataTypeFactory implements DataTypeFactory {
dataType = new String(dataItem); dataType = new String(dataItem);
} }
// @TODO: Implement Fixed/UFixed types // @TODO: Implement Fixed/UFixed types
if (!dataType) { if (_.isUndefined(dataType)) {
throw new Error(`Unrecognized data type: '${dataItem.type}'`); throw new Error(`Unrecognized data type: '${dataItem.type}'`);
} else if (parentDataType && !dataType.isStatic()) { } else if (!_.isUndefined(parentDataType) && !dataType.isStatic()) {
const pointerToDataType = new Pointer(dataType, parentDataType); const pointerToDataType = new Pointer(dataType, parentDataType);
return pointerToDataType; return pointerToDataType;
} }