F. Eugene Aumson
39c2a757be
Promote a closure to a function
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405953107
2020-04-09 18:39:46 -04:00
F. Eugene Aumson
8cdc05f582
Promote max maker response time to a global option
2020-04-09 17:21:36 -04:00
F. Eugene Aumson
5f4778c852
Don't throw when RFQ-T client isn't whitelisted
...
Addresses review comments
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405964457
and
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r406040453
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
70add44fc1
Push RFQ-T opts to SwapQuoterReqOpts subnamespace
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405969509
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
fa617d2e9d
Demote public member to private
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405963834
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
3c795d365d
Demote instance member to just constructor a arg
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405963779
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
93872ad7a3
Push RFQ-T opts to own SwapQuoterOpts subnamespace
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405963240
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
227676c150
Remove unused intentOnFilling method parameter
...
Addresses review comments
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405952889
and
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r406048104
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
5f23833b43
rm unused SwapQuoteRequestOpts key enableRfqt
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r406043111
2020-04-09 17:21:35 -04:00
F. Eugene Aumson
121d51b414
Use try...catch instead of Promise.catch()
...
Addresses review comments
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405953735
and
https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405966703
2020-04-09 17:21:34 -04:00
Jacob Evans
0e196a59d9
Always use DFB in asset-swapper ( #2542 )
...
* Always use DFB in asset-swapper
* Clean up
2020-04-09 15:52:15 +10:00
F. Eugene Aumson
63bfd23310
Pass QuoteRequestor via SwapQuoteOpts not ctor arg
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405900525
2020-04-09 00:29:58 -04:00
F. Eugene Aumson
aadcf8fed0
Parallelize RFQ-T with orderbook query
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405905572
2020-04-09 00:29:57 -04:00
F. Eugene Aumson
37390e03b4
Use Array.push instead of Array.concat
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405905052
2020-04-09 00:09:10 -04:00
F. Eugene Aumson
98fc780ade
Use map idiom instead of for loop
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405904035
2020-04-08 23:14:06 -04:00
F. Eugene Aumson
1670b21123
Use NULL_ADDRESS instead of literal
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405901406
2020-04-08 22:56:11 -04:00
F. Eugene Aumson
5602aacbd2
mk SwapQuoterOpt rfqtTakerApiKeyWhitelist optional
...
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405749147
2020-04-08 22:48:21 -04:00
Lawrence Forman
c541340ef5
Update CHANGELOG.json
...
`@0x/contract-addresses`: Redeploy `DexForwarderBridge` on Mainnet with Gas Token freeing
`@0x/contract-addresses`: Revert to older Curve Bridge (without Gas Tokens)
2020-04-07 13:41:37 -04:00
Jacob Evans
c6379ca1d4
Update DexForwarderBridge address
2020-04-07 12:35:18 -04:00
Jacob Evans
282930cb9b
Add GST support to DFB
2020-04-07 12:35:18 -04:00
Lawrence Forman
b09c751942
@0x/asset-swapper: Remove deprecated swap_quote_calculator tests
2020-04-07 12:35:18 -04:00
Lawrence Forman
b2047b90b3
@0x/asset-proxy: Fix failing test.
2020-04-07 12:35:18 -04:00
Lawrence Forman
0c8aec30bd
@0x/asset-swapper: Fix linter lies.
2020-04-07 12:35:18 -04:00
Lawrence Forman
fafaa3e69b
@0x/asset-swapper: Lint and remove @0x/contracts-asset-proxy dep.
2020-04-07 12:35:18 -04:00
Lawrence Forman
d19bb3de8d
@0x/asset-swapper: Run prettier
2020-04-07 12:35:18 -04:00
Lawrence Forman
481136166c
@0x/asset-swapper: Remove unused Order export from index.ts.
2020-04-07 12:35:18 -04:00
Lawrence Forman
4df81a0b9e
@0x/asset-swapper: add quote fill simulation tests
2020-04-07 12:35:18 -04:00
Lawrence Forman
da1e9c2d97
@0x/asset-swapper: Add DFB support + refactor swap quote calculation utils
2020-04-07 12:35:18 -04:00
F. Eugene Aumson
4b5a02c246
asset-swapper, migrations: incl. prettier in lint
2020-04-07 01:41:47 -04:00
F. Eugene Aumson
0e1572cfd7
migrations: add yarn publish:private
2020-04-07 01:41:47 -04:00
F. Eugene Aumson
343caa1ff6
migrations: Deploy ERC20BridgeSampler
2020-04-07 01:41:47 -04:00
F. Eugene Aumson
403fb3826d
asset-swapper: support firm RFQ-T quote requests
2020-04-07 01:41:47 -04:00
F. Eugene Aumson
3cdccb7b4e
prep asset-swapper: rename variable
2020-04-07 00:48:25 -04:00
Lawrence Forman
b9a68c0b8e
@0x/sol-compiler: Address review feedback.
2020-04-01 14:30:17 -04:00
Lawrence Forman
74647f0e88
@0x/sol-compiler: remove fs.promises usage
2020-04-01 13:42:48 -04:00
Lawrence Forman
6e29c8bea9
@0x/sol-compiler: Make source paths in output artifacts nicer if they're within modules.
...
`@0x/sol-compiler`: Makea Add v0.6 solidity test.
2020-04-01 13:42:48 -04:00
Lawrence Forman
b36373ab81
@0x/sol-compiler: Insert compiler version in input artifacts.
2020-04-01 13:42:48 -04:00
Lawrence Forman
dc437aacf1
@0x/sol-compiler`: Refactor + add solidity 0.6 support
2020-04-01 13:42:48 -04:00
Lawrence Forman
e19dae9b28
@0x/typescript-typings: Add version() to SolcInstance
2020-04-01 13:42:48 -04:00
Jacob Evans
424cbd4831
Forwarder Market sell specified amount or throw ( #2521 )
...
* Forwarder Market sell specified amount or throw
* Address feedback comments
* Break if we have only protocol fee remaining
* Lint
* Update deployed addresses
* Updated artifacts and wrappers
* [asset-swapper] Forwarder throws on market sell if amount not sold (#2534 )
2020-03-31 16:25:34 +10:00
Jacob Evans
7ca4aa0ff4
[asset-swapper] Fix getBatchMarketBuyOrdersAsync ( #2533 )
2020-03-31 04:21:03 +10:00
Lawrence Forman
c5a6e49681
update ganache forwarder address
2020-03-27 16:50:11 -04:00
Lawrence Forman
a509af2875
@0x/contract-addresses: Add dexForwarderBridge address.
...
`@0x/migrations`: Add `dexForwarderBridge` address field.
2020-03-27 16:40:46 -04:00
Jacob Evans
277dbacf68
Set GSTCollector address and deploy Curve ( #2530 )
...
* Set GSTCollector address and deploy Curve
* CHANGELOGs
2020-03-26 18:26:16 +10:00
Lawrence Forman
17d81bf014
@0x/contract-addresses: Fix DydxBridge mainnet/kovan address.
...
`@0x/contract-addresses`: Lowercase GodsUnchained/broker addresses.
2020-03-25 22:40:18 -04:00
Lawrence Forman
0fdd31892a
@0x/asset-swapper: Fix quote optimizer bug not properly accounting for fees.
2020-03-20 15:59:48 -04:00
Xianny
b7fb5394a7
add gitpkg to contract-wrappers ( #2520 )
2020-03-13 10:10:32 -07:00
Lawrence Forman
2b58a7242b
@0x/asset-swapper: Fix changelog.
2020-03-13 00:40:19 -04:00
Lawrence Forman
5ed919df79
@0x/asset-swapper: Fix fee schedule not being scaled by gas price.
2020-03-13 00:10:04 -04:00
Lawrence Forman
1a9063a55b
@0x/asset-swapper: Address review comments.
2020-03-11 12:24:32 -04:00