Greg Hysen
|
70863cca08
|
Ran prettier and linter
|
2018-08-24 18:20:25 -07:00 |
|
Greg Hysen
|
5a1dce15be
|
Updated all existing match order tests to use new format
|
2018-08-24 18:19:43 -07:00 |
|
Greg Hysen
|
d291256158
|
Passes comprehensive test
|
2018-08-24 18:18:30 -07:00 |
|
Greg Hysen
|
8c706ac639
|
Verify logs
|
2018-08-24 18:18:30 -07:00 |
|
Greg Hysen
|
f697814849
|
First balance test with intentional values
|
2018-08-24 18:18:30 -07:00 |
|
Greg Hysen
|
ca5c9e77c0
|
Ironing out the new set of test cases for order matchubng
|
2018-08-24 18:17:27 -07:00 |
|
Greg Hysen
|
a32b201afe
|
Rounding for fees in match orders addressed, plus example
|
2018-08-24 18:17:27 -07:00 |
|
Greg Hysen
|
0ecdf1e213
|
All existing tests pass.
|
2018-08-24 18:17:26 -07:00 |
|
Greg Hysen
|
057891b342
|
Added fees to matchOrders (previously in calculateFillResults
|
2018-08-24 18:17:26 -07:00 |
|
Greg Hysen
|
407f63ef20
|
Removed calculateFillResults from matchOrders workflow. Eliminates compounded rounding errors.
|
2018-08-24 18:17:26 -07:00 |
|
Amir Bandeali
|
f938c989e3
|
Merge pull request #1002 from 0xProject/feature/contracts/mutex
[contracts] Add mutexes and reentrancy guards
|
2018-08-24 18:15:22 -07:00 |
|
Amir Bandeali
|
c8500cab10
|
Fix build
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c28c3db63f
|
Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow variations
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
a09ee90739
|
Add tests for matchOrders
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
7d5a23969d
|
Add reentrancy tests for fillOrder and wrapper functions
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
56c3c29feb
|
Update ReentrantERC20Token with new functions and check that revert is occuring for correct reason
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c75212bef0
|
Add nonReentrant modifiers on functions that use getCurrentContextAddress only, add lockMutex modifier on functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6d0dedc62c
|
Split modifiers into check only and check, lock, unlock
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
cf12daea2f
|
Add ReentrantToken
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6f88e9bdbd
|
Add internal fill functions, add reentrancy guard to public functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
d8cb56caa3
|
Add ReentrancyGuard contract
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
044415e23d
|
Remove redundant sload from getCurrentContextAddress
|
2018-08-24 17:30:56 -07:00 |
|
Remco Bloemen
|
6b866d6053
|
Revert maker not equal taker check
|
2018-08-24 17:29:52 -07:00 |
|
Amir Bandeali
|
74ce893f52
|
Merge pull request #1003 from 0xProject/feature/contracts/roundup
[contracts] Add getPartialAmountCeil and isRoundingErrorCeil
|
2018-08-24 17:29:09 -07:00 |
|
Amir Bandeali
|
cc1fac9bbe
|
Fix linting errors
|
2018-08-24 17:02:42 -07:00 |
|
Amir Bandeali
|
94e01be9ed
|
Merge pull request #1021 from 0xProject/feature/contracts/skipselftransfer
[Contracts] Skip self transfers
|
2018-08-24 16:58:46 -07:00 |
|
Remco Bloemen
|
e215992859
|
Fix mixin api
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
e6f5cac878
|
Fix double definition of error
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
29971f36cf
|
Split into assertFillable and assertValidFill
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
3e4493b389
|
Disallow self filling
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
749c6ecc30
|
Add revert reasons to types
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
e6e7bae445
|
Remove BUG_ from revert reasons
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
a1d8943552
|
Document accetable price check
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
07e56b3cc7
|
Fix taker overpay check
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
b16f5f55fb
|
Check fillable early
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
d92fd43791
|
Update for new assertValidFill signature
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
e706fa76ac
|
Add overfill and price assertion to assertValidFill
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
11328bd93d
|
Skip self-transfers
|
2018-08-24 16:26:48 -07:00 |
|
Remco Bloemen
|
bc686fcbf3
|
Stylistic fixes
|
2018-08-24 16:17:02 -07:00 |
|
Remco Bloemen
|
80291caf7c
|
Append -Floor to getPartialAmount and isRoundingError
|
2018-08-24 16:16:44 -07:00 |
|
Brandon Millman
|
cd5e9a5115
|
Merge pull request #1018 from 0xProject/fix/migrations/order-validator-testnet
[migrations] Add testnet network info to OrderValidator artifact
|
2018-08-24 16:06:10 -07:00 |
|
Amir Bandeali
|
82b51db17e
|
Merge pull request #1015 from 0xProject/feature/contracts/removeCallerSigType
Remove SignatureType.Caller
|
2018-08-24 15:09:39 -07:00 |
|
Brandon Millman
|
3557cd93fc
|
Add testnet network info to OrderValidator artifact
|
2018-08-24 14:42:07 -07:00 |
|
Amir Bandeali
|
0629a7d143
|
Remove remaining Trezor references
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
a27112cbef
|
SignatureType.Trezor -> SignatureType.EthSign in Signature Validator tests
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
d039a1adda
|
Fixed linter in signatureUtils
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
bb4d449e92
|
Test case for Trezor Model T signature
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
241534a63d
|
Fixed trezor personal message in client+contracts; added a test using message signed by Trezor One (firmware v1.6.2)
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
1932aff35c
|
Remove Trezor SignatureType
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
4f27991959
|
Remove SigntureType.Caller from signingUtils
|
2018-08-24 14:39:08 -07:00 |
|