f11d8a5bd8
* move orderParsingUtils from order-utils to connect * Remove many functions from signatureUtils Removed from the exported object, that is. All of them are used in other existing code, so they were all moved to be as local to their usage as possible. * remove orderHashUtils.isValidOrderHash() * Move all *RevertErrors from order-utils... ...into their respective @0x/contracts- packages. * Refactor @0x/order-utils' orderHashUtils away - Move existing routines into @0x/contracts-test-utils - Migrate non-contract-test callers to a newly-exposed getOrderHash() method in DevUtils. * Move all *RevertErrors from @0x/utils... ...into their respective @0x/contracts- packages. * rm transactionHashUtils.isValidTransactionHash() * DevUtils.sol: Fail yarn test if too big to deploy * Refactor @0x/order-utils transactionHashUtils away - Move existing routines into @0x/contracts-test-utils - Migrate non-contract-test callers to a newly-exposed getTransactionHash() method in DevUtils. * Consolidate `Removed export...` CHANGELOG entries * Rm EthBalanceChecker from devutils wrapper exports * Stop importing from '.' or '.../src' * fix builds * fix prettier; dangling promise * increase max bundle size
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
import { chaiSetup } from '@0x/dev-utils';
|
|
import { Order } from '@0x/types';
|
|
import { BigNumber } from '@0x/utils';
|
|
import * as chai from 'chai';
|
|
import 'mocha';
|
|
|
|
import { orderHashUtils } from '../src';
|
|
|
|
import { constants } from '../src/constants';
|
|
|
|
chaiSetup.configure();
|
|
const expect = chai.expect;
|
|
|
|
describe('Order hashing', () => {
|
|
describe('#getOrderHashHex', () => {
|
|
const expectedOrderHash = '0x331cb7e07a757bae130702da6646c26531798c92bcfaf671817268fd2c188531';
|
|
const fakeExchangeContractAddress = '0x1dc4c1cefef38a777b15aa20260a54e584b16c48';
|
|
const fakeChainID = 50;
|
|
const order: Order = {
|
|
makerAddress: constants.NULL_ADDRESS,
|
|
takerAddress: constants.NULL_ADDRESS,
|
|
senderAddress: constants.NULL_ADDRESS,
|
|
feeRecipientAddress: constants.NULL_ADDRESS,
|
|
makerAssetData: constants.NULL_ADDRESS,
|
|
takerAssetData: constants.NULL_ADDRESS,
|
|
makerFeeAssetData: constants.NULL_ADDRESS,
|
|
takerFeeAssetData: constants.NULL_ADDRESS,
|
|
salt: new BigNumber(0),
|
|
makerFee: new BigNumber(0),
|
|
takerFee: new BigNumber(0),
|
|
makerAssetAmount: new BigNumber(0),
|
|
takerAssetAmount: new BigNumber(0),
|
|
expirationTimeSeconds: new BigNumber(0),
|
|
exchangeAddress: fakeExchangeContractAddress,
|
|
chainId: fakeChainID,
|
|
};
|
|
it('calculates the order hash', async () => {
|
|
const orderHash = orderHashUtils.getOrderHashHex(order);
|
|
expect(orderHash).to.be.equal(expectedOrderHash);
|
|
});
|
|
it('calculates the order hash if amounts are strings', async () => {
|
|
// It's common for developers using javascript to provide the amounts
|
|
// as strings. Since we eventually toString() the BigNumber
|
|
// before encoding we should result in the same orderHash in this scenario
|
|
// tslint:disable-next-line:no-unnecessary-type-assertion
|
|
const orderHash = orderHashUtils.getOrderHashHex({
|
|
...order,
|
|
makerAssetAmount: '0',
|
|
takerAssetAmount: '0',
|
|
makerFee: '0',
|
|
takerFee: '0',
|
|
} as any);
|
|
expect(orderHash).to.be.equal(expectedOrderHash);
|
|
});
|
|
it('throws a readable error message if taker format is invalid', async () => {
|
|
const orderWithInvalidtakerFormat = {
|
|
...order,
|
|
takerAddress: (null as any) as string,
|
|
};
|
|
const expectedErrorMessage = `Order taker must be of type string. If you want anyone to be able to fill an order - pass ${
|
|
constants.NULL_ADDRESS
|
|
}`;
|
|
expect(() => orderHashUtils.getOrderHashHex(orderWithInvalidtakerFormat)).to.throw(expectedErrorMessage);
|
|
});
|
|
});
|
|
});
|