crowetic/qortal
1
0
Fork 0
forked from Qortal/qortal
Code Pull Requests Activity

Discard BLOCK_SUMMARIES_V2 messages with an ID (thanks to @catbref for the code)

Browse Source 
This is a better fix for the "contaminated chain tip summaries" issue. Need to reduce the logging level to debug before release.
This commit is contained in:
CalDescent 2022-10-10 10:28:36 +01:00
parent cb1eee8ff5
commit 36fcd6792a
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/qortal/controller/Controller.java
View File

@ -1599,6 +1599,17 @@ public class Controller extends Thread {
} }
} }
if (message.hasId()) {
/*
* Experimental proof-of-concept: discard messages with ID
* These are 'late' reply messages received after timeout has expired,
* having been passed upwards from Peer to Network to Controller.
* Hence, these are NOT simple "here's my chain tip" broadcasts from other peers.
*/
LOGGER.info("Discarding late {} message with ID {} from {}", message.getType().name(), message.getId(), peer);
return;
}
// Update peer chain tip data // Update peer chain tip data
peer.setChainTipSummaries(blockSummariesV2Message.getBlockSummaries()); peer.setChainTipSummaries(blockSummariesV2Message.getBlockSummaries());