crowetic/qortal
1
0
Fork 0
forked from Qortal/qortal
Code Pull Requests Activity

Fix rounding issue when checking whether tx meets approval threshold

Browse Source
This commit is contained in:
catbref 2020-01-07 14:23:09 +00:00
parent 8ba11efbd4
commit 7a7ca4b684
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/qora/group/Group.java
View File

@ -62,7 +62,11 @@ public class Group {
if (!this.isPercentage)
return currentApprovals >= this.value;
return currentApprovals >= (totalAdmins * this.value / 100);
// Multiply currentApprovals by 100 instead of dividing right-hand-side by 100 to prevent rounding errors!
// Examples using 2 current approvals, 4 total admins, 60% threshold:
// WRONG: 2 >= 4 * 60 / 100, i.e. 2 >= (240 / 100) which rounds to: 2 >= 2, returns true
// RIGHT: 2 * 100 >= 4 * 60, i.e. 200 >= 240, returns false
return (currentApprovals * 100) >= (totalAdmins * this.value);
}
}