Qortal/qortal
1
0
Fork 0
mirror of https://github.com/Qortal/qortal.git synced 2025-05-08 02:37:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better handling of RPC errors.

Browse Source 
Previously, if an error was returned from an Electrum server (such as "server busy") it would throw a NetworkException that would be caught outside of the server loop and cause the entire request to fail.

Instead of throwing an exception, I am now logging the error and returning null, in the same way we do for IOException and NoSuchElementException further up in the same method.

This allows the caller - most likely connectedRpc() - to move on to the next server in the list and try again.

This should fix an issue seen where a "server busy" response from a single server was essentially breaking our implementation, as we would give up altogether instead of trying another server.
This commit is contained in:
CalDescent 2021-08-11 19:22:53 +01:00
parent 3b6ba7641d
commit 112675c782
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/main/java/org/qortal/crosschain/ElectrumX.java
View File

@ -653,18 +653,27 @@ public class ElectrumX extends BitcoinyBlockchainProvider {
Object errorObj = responseJson.get("error"); Object errorObj = responseJson.get("error");
if (errorObj != null) { if (errorObj != null) {
if (errorObj instanceof String) if (errorObj instanceof String) {
throw new ForeignBlockchainException.NetworkException(String.format("Unexpected error message from ElectrumX RPC %s: %s", method, (String) errorObj), this.currentServer); LOGGER.debug(String.format("Unexpected error message from ElectrumX RPC %s: %s", method, (String) errorObj), this.currentServer);
// Try another server
return null;
}
if (!(errorObj instanceof JSONObject)) if (!(errorObj instanceof JSONObject)) {
throw new ForeignBlockchainException.NetworkException(String.format("Unexpected error response from ElectrumX RPC %s", method), this.currentServer); LOGGER.debug(String.format("Unexpected error response from ElectrumX RPC %s", method), this.currentServer);
// Try another server
return null;
}
JSONObject errorJson = (JSONObject) errorObj; JSONObject errorJson = (JSONObject) errorObj;
Object messageObj = errorJson.get("message"); Object messageObj = errorJson.get("message");
if (!(messageObj instanceof String)) if (!(messageObj instanceof String)) {
throw new ForeignBlockchainException.NetworkException(String.format("Missing/invalid message in error response from ElectrumX RPC %s", method), this.currentServer); LOGGER.debug(String.format("Missing/invalid message in error response from ElectrumX RPC %s", method), this.currentServer);
// Try another server
return null;
}
String message = (String) messageObj; String message = (String) messageObj;