crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2566 from 0xProject/fix/dangling-promises-asset-swapper

Browse Source 
[asset-swapper] Fixed dangling promises
This commit is contained in:
Alex Towle
2020-04-24 16:53:30 -05:00
committed by GitHub
parent 501070bfb0 44d626e12e
commit 160519e1fe
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/asset-swapper/src/swap_quoter.ts
View File

@@ -309,13 +309,12 @@ export class SwapQuoter {
assert.isBigNumber('makerAssetBuyAmount', makerAssetBuyAmount);
const makerAssetData = assetDataUtils.encodeERC20AssetData(makerTokenAddress);
const takerAssetData = assetDataUtils.encodeERC20AssetData(takerTokenAddress);
const swapQuote = this.getMarketBuySwapQuoteForAssetDataAsync(
return this.getMarketBuySwapQuoteForAssetDataAsync(
makerAssetData,
takerAssetData,
makerAssetBuyAmount,
options,
);
return swapQuote;
}
/**
@@ -339,13 +338,12 @@ export class SwapQuoter {
assert.isBigNumber('takerAssetSellAmount', takerAssetSellAmount);
const makerAssetData = assetDataUtils.encodeERC20AssetData(makerTokenAddress);
const takerAssetData = assetDataUtils.encodeERC20AssetData(takerTokenAddress);
const swapQuote = this.getMarketSellSwapQuoteForAssetDataAsync(
return this.getMarketSellSwapQuoteForAssetDataAsync(
makerAssetData,
takerAssetData,
takerAssetSellAmount,
options,
);
return swapQuote;
}
/**