crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix typos and remove redundant cached variables

Browse Source
This commit is contained in:
Amir Bandeali
2019-09-17 13:50:18 -07:00
parent 0d441a829f
commit 2d125cdc20
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
contracts/staking/contracts/src/stake/MixinZrxVault.sol
View File

@@ -33,8 +33,7 @@ contract MixinZrxVault is
function _depositFromOwnerIntoZrxVault(address owner, uint256 amount)
internal
{
IZrxVault _zrxVault = zrxVault;
_zrxVault.depositFrom(owner, amount);
zrxVault.depositFrom(owner, amount);
}
/// @dev Withdraws Zrx Tokens from to `owner` from the vault.
@@ -43,8 +42,7 @@ contract MixinZrxVault is
function _withdrawToOwnerFromZrxVault(address owner, uint256 amount)
internal
{
IZrxVault _zrxVault = zrxVault;
_zrxVault.withdrawFrom(owner, amount);
zrxVault.withdrawFrom(owner, amount);
}
/// @dev Returns balance of `owner` in the ZRX ault.
@@ -54,7 +52,6 @@ contract MixinZrxVault is
view
returns (uint256)
{
IZrxVault _zrxVault = zrxVault;
return _zrxVault.balanceOf(owner);
return zrxVault.balanceOf(owner);
}
}

2
contracts/staking/contracts/src/sys/MixinParams.sol
View File

@@ -111,7 +111,7 @@ contract MixinParams is
_zrxVaultAddress = address(zrxVault);
}
/// @dev Initialzize storage belonging to this mixin.
/// @dev Initialize storage belonging to this mixin.
/// @param _wethProxyAddress The address that can transfer WETH for fees.
/// @param _ethVaultAddress Address of the EthVault contract.
/// @param _rewardVaultAddress Address of the StakingPoolRewardVault contract.

3
contracts/staking/test/migration.ts
View File

@@ -89,9 +89,8 @@ blockchainTests('Migration tests', env => {
});
it('throws if not called by owner', async () => {
const attachedAddress = randomAddress();
const tx = proxyContract.attachStakingContract.awaitTransactionSuccessAsync(
attachedAddress,
initTargetContract.address,
constants.NULL_ADDRESS,
constants.NULL_ADDRESS,
constants.NULL_ADDRESS,