Wrapped up tests for compliant forwarder

This commit is contained in:
Greg Hysen
2018-11-29 14:05:04 -08:00
parent 33e41dd500
commit 3f7bd24250
2 changed files with 15 additions and 5 deletions

View File

@@ -93,12 +93,13 @@ contract CompliantForwarder {
"MAKER_UNVERIFIED"
);
/*
// All entities are verified. Execute fillOrder.
EXCHANGE.executeTransaction(
salt,
signerAddress,
signedFillOrderTransaction,
signature
);
);*/
}
}

View File

@@ -273,14 +273,25 @@ describe.only(ContractName.CompliantForwarder, () => {
signedFillOrderTx.signature,
));
});
it('should revert if taker address is not compliant (does not hold a Yes Token)', async () => {
return expectTransactionFailedAsync(
compliantForwarderInstance.fillOrder.sendTransactionAsync(
compliantSignedFillOrderTx.salt,
nonCompliantAddress,
compliantSignedFillOrderTx.data,
compliantSignedFillOrderTx.signature,
),
RevertReason.TakerUnverified
);
});
it('should revert if maker address is not compliant (does not hold a Yes Token)', async () => {
// Create signed order with non-compliant maker address
const signedOrderWithBadSenderAddress = await orderFactory.newSignedOrderAsync({
const signedOrderWithBadMakerAddress = await orderFactory.newSignedOrderAsync({
senderAddress: compliantForwarderInstance.address,
makerAddress: nonCompliantAddress
});
const signedOrderWithoutExchangeAddress = orderUtils.getOrderWithoutExchangeAddress(
signedOrderWithBadSenderAddress,
signedOrderWithBadMakerAddress,
);
const signedOrderWithoutExchangeAddressData = exchangeInstance.fillOrder.getABIEncodedTransactionData(
signedOrderWithoutExchangeAddress,
@@ -301,8 +312,6 @@ describe.only(ContractName.CompliantForwarder, () => {
RevertReason.MakerUnverified
);
});
// @TODO: Should fail if maker is not verified
// @TODO: Should fail it taker is not verified
});
});
// tslint:disable:max-file-line-count