Return after checking for an error and add an explanatory comment

2018-01-12 21:39:51 +01:00
parent 5b6f8d4c3f
commit 6a56f20928
1 changed files with 2 additions and 1 deletions
--- a/packages/0x.js/src/order_watcher/order_state_watcher.ts
+++ b/packages/0x.js/src/order_watcher/order_state_watcher.ts
@@ -221,8 +221,9 @@ export class OrderStateWatcher {
                this._callbackIfExists(err);
                this.unsubscribe();
            }
+            return;
        }
-        const log = logIfExists as LogEvent;
+        const log = logIfExists as LogEvent; // At this moment we are sure that no error occured and log is defined.
        const maybeDecodedLog = this._abiDecoder.tryToDecodeLogOrNoop(log);
        const isLogDecoded = !_.isUndefined((maybeDecodedLog as LogWithDecodedArgs<any>).event);
        if (!isLogDecoded) {