crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1949 from 0xProject/feature/fix-monorepo-scripts

Browse Source 
Fix case in pre-publish write access checks
This commit is contained in:
David Sun
2019-07-12 14:00:35 -07:00
committed by GitHub
parent 212a2d229a ddc5aaacdb
commit 80caa16718
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/monorepo-scripts/src/prepublish_checks.ts
View File

@@ -148,7 +148,15 @@ async function checkPublishRequiredSetupAsync(updatedPublicPackages: Package[]):
const writePermissions = Object.keys(pkgPermissions).filter(pkgName => {
return pkgPermissions[pkgName] === 'read-write';
});
const unwriteablePkgs = updatedPublicPackages.filter(pkg => !writePermissions.includes(pkg.packageJson.name));
const unwriteablePkgs = [];
for (const pkg of updatedPublicPackages) {
const isPackagePublished =
(await npmUtils.getPackageRegistryJsonIfExistsAsync(pkg.packageJson.name)) !== undefined;
const isPackageWritePermissionsGranted = writePermissions.includes(pkg.packageJson.name);
if (isPackagePublished && !isPackageWritePermissionsGranted) {
unwriteablePkgs.push(pkg);
}
}
if (unwriteablePkgs.length > 0) {
utils.log(`Missing write permissions for the following packages:`);
unwriteablePkgs.forEach(pkg => {