add and test support for return comment

This commit is contained in:
F. Eugene Aumson
2018-09-17 17:27:33 -04:00
parent 5b07669bd0
commit 9201273939
2 changed files with 12 additions and 0 deletions

View File

@@ -176,6 +176,11 @@ function _genMethodDoc(
? { name: '', typeDocType: TypeDocTypes.Intrinsic }
: _genMethodReturnTypeDoc(abiDefinition.outputs, methodSignature, devdocIfExists);
const returnComment =
_.isUndefined(devdocIfExists) || _.isUndefined(devdocIfExists.methods[methodSignature])
? undefined
: devdocIfExists.methods[methodSignature].return;
const isConstant = abiDefinition.type === 'fallback' ? true : abiDefinition.constant;
// TODO: determine whether fallback functions are always constant, as coded just above
@@ -185,6 +190,7 @@ function _genMethodDoc(
callPath: '', // TODO: wtf is this?
parameters,
returnType,
returnComment,
isConstant,
isPayable: abiDefinition.payable,
comment,

View File

@@ -84,6 +84,9 @@ describe('#SolidityDocGenerator', () => {
it('return type name', () => {
expect(methodDoc.returnType.name).to.equal('r');
});
it('return comment', () => {
expect(methodDoc.returnComment).to.equal('publicMethod @return');
});
});
describe('should emit external method documentation for', () => {
let methodDoc: SolidityMethod;
@@ -111,6 +114,9 @@ describe('#SolidityDocGenerator', () => {
it('return type name', () => {
expect(methodDoc.returnType.name).to.equal('r');
});
it('return comment', () => {
expect(methodDoc.returnComment).to.equal('externalMethod @return');
});
});
it('should not truncate a multi-line devdoc comment', () => {
// tslint:disable-next-line:no-unnecessary-type-assertion