crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asset-s: Clarify indicative quote enablement

Browse Source 
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2555#discussion_r411498729
This commit is contained in:
F. Eugene Aumson
2020-04-20 22:44:50 -04:00
parent 245b6da577
commit ba2ac6a7b5
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/asset-swapper/src/swap_quoter.ts
View File

@@ -566,13 +566,8 @@ export class SwapQuoter {
let swapQuote: SwapQuote;
const calcOpts: CalculateSwapQuoteOpts = opts;
if (
// we should request indicative quotes:
calcOpts.rfqt &&
!calcOpts.rfqt.intentOnFilling &&
calcOpts.rfqt.apiKey &&
this._rfqtTakerApiKeyWhitelist.includes(calcOpts.rfqt.apiKey)
) {
if (calcOpts.rfqt !== undefined && this._shouldEnableIndicativeRfqt(calcOpts.rfqt)) {
calcOpts.rfqt.quoteRequestor = this._quoteRequestor;
}
@@ -594,5 +589,8 @@ export class SwapQuoter {
return swapQuote;
}
private _shouldEnableIndicativeRfqt(opts: CalculateSwapQuoteOpts['rfqt']): boolean {
return opts !== undefined && !opts.intentOnFilling && this._rfqtTakerApiKeyWhitelist.includes(opts.apiKey);
}
}
// tslint:disable-next-line: max-file-line-count