crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix error were object could be undefined given an approval event

Browse Source
This commit is contained in:
Jacob Evans
2019-03-13 22:41:35 +01:00
parent af04c294b9
commit f2857452e3
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/order-watcher/CHANGELOG.json
View File

@@ -5,6 +5,9 @@
{
"note": "Update websocket from ^1.0.25 to ^1.0.26",
"pr": 1685
},
{
"note": "Fix issue where ERC721 Approval events could cause a lookup on undefined object"
}
]
},

12
packages/order-watcher/src/order_watcher/dependent_order_hashes_tracker.ts
View File

@@ -37,9 +37,15 @@ export class DependentOrderHashesTracker {
this._zrxTokenAddress = zrxTokenAddress;
}
public getDependentOrderHashesByERC721ByMaker(makerAddress: string, tokenAddress: string): string[] {
const orderHashSets = _.values(
this._orderHashesByERC721AddressByTokenIdByMakerAddress[makerAddress][tokenAddress],
);
let orderHashSets: Array<Set<string>> = [];
if (
this._orderHashesByERC721AddressByTokenIdByMakerAddress[makerAddress] &&
this._orderHashesByERC721AddressByTokenIdByMakerAddress[makerAddress][tokenAddress]
) {
orderHashSets = _.values(
this._orderHashesByERC721AddressByTokenIdByMakerAddress[makerAddress][tokenAddress],
);
}
const orderHashList = _.reduce(
orderHashSets,
(accumulator, orderHashSet) => [...accumulator, ...orderHashSet],