Greg Hysen
|
407f63ef20
|
Removed calculateFillResults from matchOrders workflow. Eliminates compounded rounding errors.
|
2018-08-24 18:17:26 -07:00 |
|
Amir Bandeali
|
f938c989e3
|
Merge pull request #1002 from 0xProject/feature/contracts/mutex
[contracts] Add mutexes and reentrancy guards
|
2018-08-24 18:15:22 -07:00 |
|
Amir Bandeali
|
c8500cab10
|
Fix build
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c28c3db63f
|
Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow variations
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
a09ee90739
|
Add tests for matchOrders
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
7d5a23969d
|
Add reentrancy tests for fillOrder and wrapper functions
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
56c3c29feb
|
Update ReentrantERC20Token with new functions and check that revert is occuring for correct reason
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c75212bef0
|
Add nonReentrant modifiers on functions that use getCurrentContextAddress only, add lockMutex modifier on functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6d0dedc62c
|
Split modifiers into check only and check, lock, unlock
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
cf12daea2f
|
Add ReentrantToken
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6f88e9bdbd
|
Add internal fill functions, add reentrancy guard to public functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
d8cb56caa3
|
Add ReentrancyGuard contract
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
044415e23d
|
Remove redundant sload from getCurrentContextAddress
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
74ce893f52
|
Merge pull request #1003 from 0xProject/feature/contracts/roundup
[contracts] Add getPartialAmountCeil and isRoundingErrorCeil
|
2018-08-24 17:29:09 -07:00 |
|
Amir Bandeali
|
cc1fac9bbe
|
Fix linting errors
|
2018-08-24 17:02:42 -07:00 |
|
Amir Bandeali
|
94e01be9ed
|
Merge pull request #1021 from 0xProject/feature/contracts/skipselftransfer
[Contracts] Skip self transfers
|
2018-08-24 16:58:46 -07:00 |
|
Remco Bloemen
|
11328bd93d
|
Skip self-transfers
|
2018-08-24 16:26:48 -07:00 |
|
Remco Bloemen
|
bc686fcbf3
|
Stylistic fixes
|
2018-08-24 16:17:02 -07:00 |
|
Remco Bloemen
|
80291caf7c
|
Append -Floor to getPartialAmount and isRoundingError
|
2018-08-24 16:16:44 -07:00 |
|
Brandon Millman
|
cd5e9a5115
|
Merge pull request #1018 from 0xProject/fix/migrations/order-validator-testnet
[migrations] Add testnet network info to OrderValidator artifact
|
2018-08-24 16:06:10 -07:00 |
|
Amir Bandeali
|
82b51db17e
|
Merge pull request #1015 from 0xProject/feature/contracts/removeCallerSigType
Remove SignatureType.Caller
|
2018-08-24 15:09:39 -07:00 |
|
Brandon Millman
|
3557cd93fc
|
Add testnet network info to OrderValidator artifact
|
2018-08-24 14:42:07 -07:00 |
|
Amir Bandeali
|
0629a7d143
|
Remove remaining Trezor references
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
a27112cbef
|
SignatureType.Trezor -> SignatureType.EthSign in Signature Validator tests
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
d039a1adda
|
Fixed linter in signatureUtils
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
bb4d449e92
|
Test case for Trezor Model T signature
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
241534a63d
|
Fixed trezor personal message in client+contracts; added a test using message signed by Trezor One (firmware v1.6.2)
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
1932aff35c
|
Remove Trezor SignatureType
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
4f27991959
|
Remove SigntureType.Caller from signingUtils
|
2018-08-24 14:39:08 -07:00 |
|
Amir Bandeali
|
8ce4f9c784
|
Remove SignatureType.Caller
|
2018-08-24 14:39:08 -07:00 |
|
Amir Bandeali
|
7351bf0b14
|
Merge pull request #1012 from 0xProject/feature/contracts/staticcall
Use staticcall for external function calls in MixinSignatureValidator
|
2018-08-24 14:38:54 -07:00 |
|
Remco Bloemen
|
f6080367fe
|
Disambiguate the operator precedence
|
2018-08-24 14:11:45 -07:00 |
|
Remco Bloemen
|
7f78d7da9d
|
Add tests
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
6734f2f1bc
|
Add docs
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
0fb7617a78
|
Fix incorect modulus
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
4219af1430
|
Add DIVISION_BY_ZERO to getPartialAmount for consistency
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
c109d1f545
|
Remove .only
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
50fab9feb3
|
Improve getPartialAmountCeil docs
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
3dad6ee55e
|
Add tests for getPartialAmountCeil
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
5d70df771b
|
Add isRoundingErrorCeil
|
2018-08-24 14:09:50 -07:00 |
|
Remco Bloemen
|
ab5df342e1
|
Add getPartialAmountCeil
|
2018-08-24 14:09:50 -07:00 |
|
Amir Bandeali
|
6a9669a409
|
Rethrow Wallet and Validator errors
|
2018-08-24 14:06:46 -07:00 |
|
Remco Bloemen
|
e68942ee78
|
Handle zero case
|
2018-08-24 13:45:10 -07:00 |
|
Remco Bloemen
|
4159e45aff
|
Update tests
|
2018-08-24 13:45:10 -07:00 |
|
Remco Bloemen
|
92497d7df4
|
Fix isRoundingError
|
2018-08-24 13:45:10 -07:00 |
|
Amir Bandeali
|
070eff6f3a
|
Rename TestStaticCall => TestStaticCallReceiver
|
2018-08-24 13:32:04 -07:00 |
|
Amir Bandeali
|
681ed822ec
|
Revert if undefined function called in AssetProxies
|
2018-08-24 13:19:07 -07:00 |
|
Amir Bandeali
|
0a1ae2c311
|
Remove pragma experimental v0.5.0 and use staticcall is assembly
|
2018-08-24 13:19:07 -07:00 |
|
Amir Bandeali
|
c5f8b9c2d2
|
Add pragma experimental v0.5.0 to SignatureValidator and add tests
|
2018-08-24 13:19:07 -07:00 |
|
Francesco Agosti
|
7f36574a57
|
Merge pull request #1011 from 0xProject/sra-api/rename/sra-spec
[sra-spec] Rename the sra-api package to sra-spec
|
2018-08-24 12:00:39 -07:00 |
|