Lawrence Forman
b8f056b82f
Update coordinator, exchange-forwarder, exchange-libs, exchange, and extensions contract tests to use new order and transaction structure
2019-07-23 15:08:00 -07:00
Lawrence Forman
259b463b73
Update contracts/test-utils to use new Order structure and domain schema.
2019-07-23 15:08:00 -07:00
Lawrence Forman
4aae7348d1
Update fill-scenarios, contract-wrappers, contract-artifacts, abi-gen-wrappers to use new domain schema and Order format.
2019-07-23 15:08:00 -07:00
Lawrence Forman
665942a8c9
Update order-utils package for new Order structure
2019-07-23 15:04:46 -07:00
Lawrence Forman
dc9a26ae8a
Update packages/utils tests to conform to new domain schema
2019-07-23 15:04:46 -07:00
Lawrence Forman
55f3322576
Rename eip712domain field in Order and ZeroExTransaction to just domain.
2019-07-23 15:04:46 -07:00
Lawrence Forman
376f068719
Add eip712DomainSchema to json-schemas.
...
Add required field `domain` to `order` and `zeroExTransaction` schemas.
2019-07-23 15:04:46 -07:00
Lawrence Forman
3688956ee5
Switch eip712 domain field verifyingContract to verifyingContractAddress
2019-07-23 15:04:46 -07:00
Lawrence Forman
53b1037a33
contracts/exchange-libs/contracts/test/TestLibs now inherits from LibEIP712ExchangeDomain rather than LibEIP712
2019-07-23 15:04:46 -07:00
Lawrence Forman
2b5cd02bd9
Remove deleted coordinator test contracts that accidentally survived the rebase
2019-07-23 15:04:46 -07:00
Lawrence Forman
e5fed57b8b
Make contracts/exchange-libs/.../LibEIP712.sol stateless
2019-07-23 15:04:46 -07:00
Lawrence Forman
a0b1f3efa2
Fix typo in exchange-libs test.
2019-07-23 15:04:46 -07:00
Lawrence Forman
f7fb1225d2
Add more LibEIP712 tests to exchange-libs
2019-07-23 15:04:46 -07:00
Lawrence Forman
b380952ff9
Add test to exchange-libs to ensure that a different chainId results in a different order hash.
2019-07-23 15:04:46 -07:00
Lawrence Forman
2524e7eea3
Update changelogs
2019-07-23 15:04:46 -07:00
Lawrence Forman
32460f00f8
Add chainId to order json-schemas tests.
2019-07-23 14:59:31 -07:00
Lawrence Forman
d58d7f457d
Update coordinator decodeOrdersFromFillData tests to include chainId
2019-07-23 14:59:31 -07:00
Lawrence Forman
232a43f34f
Update contract-wrappers tests.
2019-07-23 14:59:31 -07:00
Lawrence Forman
94f5a039d2
Update migrations for coordinator and exchange contracts.
2019-07-23 14:59:31 -07:00
Lawrence Forman
7a4ae74727
Add chainId to order JSON schema
2019-07-23 14:59:31 -07:00
Lawrence Forman
1295de4c78
Update generated wrappers for coordinator and exchange.
2019-07-23 14:59:31 -07:00
Lawrence Forman
77ed54f64d
Ran prettier
2019-07-23 14:58:00 -07:00
Lawrence Forman
e51b425200
Unpin coordinator deps.
...
Update coordinator tests for new tooling.
Remove unecessary `chainId` parameter in `eip712_utils.createCoordinatorApprovalTypeData`
2019-07-23 14:58:00 -07:00
Lawrence Forman
e6aff19a0c
Clearer usage of chainId constants in order-utils tests.
2019-07-23 14:58:00 -07:00
Lawrence Forman
bd06c7b343
Remove lingering invalid calls to OrderStateUtils()
2019-07-23 14:58:00 -07:00
Lawrence Forman
c096eae644
All glory to the linter gods.
2019-07-23 14:58:00 -07:00
Lawrence Forman
f77823ee24
Remove unused chainId variables in signature_utils.ts.
...
Obey the linter gods.
2019-07-23 14:58:00 -07:00
Lawrence Forman
35f568e346
Update exchange-forwarder tests.
2019-07-23 14:58:00 -07:00
Lawrence Forman
2d28fde24d
Migrate all contract-related tooling and tests to accept a chain ID in domain separators.
2019-07-23 14:58:00 -07:00
Lawrence Forman
92fe720ac3
Remove unused LibOrder inheritance from MixinBalanceThresholdFilterCore from /contracts/extensions.
2019-07-23 14:58:00 -07:00
Lawrence Forman
74a9a13564
Unpin @0x/contracts-exchange dependency in /contracts/coordinator.
...
Split up EIP712 constants and functionality in `/contracts/exchange-libs` across 3, modular contracts.
Make coordinator inherit from the modular EIP712 contracts in `@0x\contracts-exchange`.
2019-07-23 14:58:00 -07:00
Lawrence Forman
7aaef5d807
Fix missing comma in LibEIP712.sol domain schema.
...
Add `chainId` to constructors for all test contracts deriving from `LibEIP712.sol`
2019-07-23 14:58:00 -07:00
Lawrence Forman
64b4158bad
Refactor EIP712 contracts to reduce code duplication.
2019-07-23 14:58:00 -07:00
Lawrence Forman
4bbaa6b41c
Update tooling/types to incorporate chainID in domain separators.
2019-07-23 14:58:00 -07:00
Lawrence Forman
964d8171dd
Update exchange and coordinator contracts to incorporate chainID in their domain separators.
2019-07-23 14:58:00 -07:00
Lawrence Forman
5b1cbbf157
Fix merge artifact in contracts/exchange/CHANGELOG.json.
...
Correct changelog for `contracts/exchange-forwarder` after rebase.
2019-07-23 14:58:00 -07:00
Lawrence Forman
db4c29a73c
Apply and mask to assembly address instruction in exchange/.../ReentrantERC20Token.sol
2019-07-23 14:58:00 -07:00
Lawrence Forman
4f73008d95
Fix typo in changelog
2019-07-23 14:58:00 -07:00
Lawrence Forman
1b73cb28f1
Update changelog
2019-07-23 14:58:00 -07:00
Lawrence
367c981642
Update changelogs
2019-07-23 14:58:00 -07:00
Lawrence Forman
3d30eb0748
Remove sol-doc from circlci
2019-07-23 14:58:00 -07:00
Lawrence Forman
34ffdad521
Manually build @0x/monorepo-scripts
2019-07-23 14:58:00 -07:00
Lawrence Forman
4f82c0c289
Edit circleci config to omit tests we aren't interested in for 3.0
2019-07-23 14:58:00 -07:00
Lawrence
fd68746dd7
Fix typo in docstring for ReentrantERC20Token.createOrders.
2019-07-23 14:54:24 -07:00
Lawrence
bec7d1265b
Fix styling issues in ReentrantERC20Token.
...
Apply gas golfing suggestions in ReentrantERC20Token.
Describe ERC20 AssetData format in ReentrantERC20Token.
2019-07-23 14:54:24 -07:00
Lawrence
620eb2a3be
Shave off an SLOAD op in ReentrancyGuard.
2019-07-23 14:54:24 -07:00
Lawrence
e6971c45c8
Update PRs in changelogs.
2019-07-23 14:54:24 -07:00
Lawrence
961cd0825c
Add comment to ReentrantERC20Token about proper testing procedure
2019-07-23 14:54:24 -07:00
Lawrence
a1cb702ecb
Update changelogs
2019-07-23 14:54:24 -07:00
Lawrence
befc14c980
Ran linter
2019-07-23 14:52:57 -07:00
