CalDescent
434038fd12
Reduced online accounts log spam
2022-06-26 16:34:04 +01:00
CalDescent
a9b154b783
Modified BlockMinter.higherWeightChainExists() so that it checks for invalid blocks before treating a chain as higher weight. Otherwise minting is slowed down when a higher weight but invalid chain exists on the network (e.g. after a hard fork).
2022-06-26 15:54:41 +01:00
CalDescent
a01652b816
Removed hasInvalidBlock filtering, as this was unnecessary risk now that the original bug in comparePeers() is fixed.
2022-06-26 10:09:24 +01:00
CalDescent
4440e82bb9
Fixed long term bug in comparePeers() causing peers with invalid blocks to prevent alternate valid but lower weight candidates from being chosen.
2022-06-25 16:34:42 +01:00
CalDescent
a2e1efab90
Synchronize hasInvalidBlock predicate, as it wasn't thread safe
2022-06-25 14:12:21 +01:00
CalDescent
7e1ce38f0a
Fixed major bug in hasInvalidBlock predicate
2022-06-25 14:11:25 +01:00
CalDescent
a93bae616e
Invalid signatures are now stored as ByteArray instead of String, to avoid regular Base58 encoding and decoding, which is very inefficient.
2022-06-25 13:29:53 +01:00
CalDescent
a2568936a0
Synchronizer: filter out peers reporting to hold invalid block signatures.
...
We already mark peers as misbehaved if they returned invalid signatures, but this wasn't sufficient when multiple copies of the same invalid block exist on the network (e.g. after a hard fork). In these cases, we need to be more proactive to avoid syncing with these peers, to increase the chances of preserving other candidate blocks.
2022-06-25 12:45:19 +01:00
CalDescent
23408827b3
Merge remote-tracking branch 'catbref/schnorr-agg-BlockMinter-fix' into schnorr-agg-BlockMinter-fix
...
# Conflicts:
# src/main/java/org/qortal/block/BlockChain.java
# src/main/java/org/qortal/controller/OnlineAccountsManager.java
# src/main/java/org/qortal/network/message/BlockV2Message.java
# src/main/resources/blockchain.json
# src/test/resources/test-chain-v2.json
2022-06-24 11:47:58 +01:00
CalDescent
ae6e2fab6f
Rewrite of isNotOldPeer predicate, to fix logic issue (second attempt - first had too many issues)
...
Previously, a peer would be continuously considered not 'old' if it had a connection attempt in the past day. This prevented some peers from being removed, causing nodes to hold a large repository of peers. On slower systems, this large number of known peers resulted in low numbers of outbound connections being made, presumably because of the time taken to iterate through dataset, using up a lot of allKnownPeers lock time.
On devices that experienced the problem, it could be solved by deleting all known peers. This adds confidence that the old peers were the problem.
2022-06-24 10:36:06 +01:00
CalDescent
3af36644c0
Revert "Rewrite of isNotOldPeer predicate, to fix logic issue."
...
This reverts commit d81071f254
2022-06-24 10:26:39 +01:00
CalDescent
db8f627f1a
Default minPeerVersion set to 3.3.7
2022-06-24 10:13:55 +01:00
CalDescent
5db0fa080b
Prune peers every 5 minutes instead of every cycle of the Controller thread.
...
This should reduce the amount of time the allKnownPeers lock is held.
2022-06-24 10:13:36 +01:00
CalDescent
d81071f254
Rewrite of isNotOldPeer predicate, to fix logic issue.
...
Previously, a peer would be continuously considered not 'old' if it had a connection attempt in the past day. This prevented some peers from being removed, causing nodes to hold a large repository of peers. On slower systems, this large number of known peers resulted in low numbers of outbound connections being made, presumably because of the time taken to iterate through dataset, using up a lot of allKnownPeers lock time.
On devices that experienced the problem, it could be solved by deleting all known peers. This adds confidence that the old peers were the problem.
2022-06-24 10:11:46 +01:00
ba148dfd88
Added Korean translations
...
credit: TL (Discord username)
2022-06-23 02:35:42 -04:00
CalDescent
dbcb457a04
Merge branch 'master' of github.com:Qortal/qortal
2022-06-20 22:51:33 +01:00
CalDescent
b00e1c8f47
Allow online account submission in all cases when in recovery mode.
2022-06-20 22:50:41 +01:00
CalDescent
899a6eb104
Rework of systray statuses
...
- Show "Minting" as long as online accounts are submitted to the network (previously it related to block signing).
- Fixed bug causing it to regularly show "Synchronizing 100%".
- Only show "Synchronizing" if the chain falls more than 2 hours behind - anything less is unnecessary noise.
2022-06-20 22:48:32 +01:00
CalDescent
6e556c82a3
Updated AdvancedInstaller project for v3.3.7
2022-06-20 22:25:40 +01:00
CalDescent
35ce64cc3a
Bump version to 3.3.7
2022-06-20 21:52:41 +01:00
CalDescent
09b218d16c
Merge branch 'master' of github.com:Qortal/qortal
2022-06-20 21:51:39 +01:00
CalDescent
7ea451e027
Allow trades to be initiated, and QDN data to be published, as long as the latest block is within 60 minutes of the current time. Again this should remove negative effects of larger re-orgs from the UX.
2022-06-20 21:26:48 +01:00
CalDescent
ffb27c3946
Further relaxed min latest block timestamp age to be considered "up to date" in a few places, from 30 to 60 mins. This should help reduce the visible effects of larger re-orgs if they happen again.
2022-06-20 21:25:14 +01:00
6e7d2b50a0
Added Romanian translations
...
credit: Ovidiu (Telegram username)
2022-06-20 01:27:28 -04:00
bd025f30ff
Updated ApiError German translations
...
credit: CD (Discord username)
2022-06-20 00:56:19 -04:00
CalDescent
c6cbd8e826
Revert "Sync behaviour changes:"
...
This reverts commit 8a76c6c0de
2022-06-19 19:10:37 +01:00
CalDescent
b85afe3ca7
Revert "Keep existing findCommonBlocksWithPeers() and comparePeers() behaviour prior to consensus switchover, to reduce the number of variables."
...
This reverts commit fecfac5ad9
2022-06-19 19:10:30 +01:00
CalDescent
5a4674c973
Revert "newConsensusTimestamp set to Sun Jun 19 2022 16:00:00 UTC"
...
This reverts commit 55a0c10855
2022-06-19 19:09:57 +01:00
CalDescent
769418e5ae
Revert "Fixed unit tests due to missing feature trigger"
...
This reverts commit 28f9df7178
2022-06-19 19:09:52 +01:00
CalDescent
38faed5799
Don't submit online accounts if node is more than 2 hours of sync.
2022-06-19 18:56:08 +01:00
CalDescent
96cdf4a87e
Updated AdvancedInstaller project for v3.3.6
2022-06-19 11:41:50 +01:00
CalDescent
c0b1580561
Bump version to 3.3.6
2022-06-17 20:42:51 +01:00
CalDescent
28f9df7178
Fixed unit tests due to missing feature trigger
2022-06-17 13:07:33 +01:00
CalDescent
55a0c10855
newConsensusTimestamp set to Sun Jun 19 2022 16:00:00 UTC
2022-06-17 13:04:04 +01:00
CalDescent
7c5165763d
Merge branch 'sync-long-tip'
2022-06-17 13:02:08 +01:00
CalDescent
d2836ebcb9
Make sure to set the ID when rebroadcasting messages. Hopeful fix for QDN networking issues.
2022-06-16 22:39:51 +01:00
CalDescent
fecfac5ad9
Keep existing findCommonBlocksWithPeers() and comparePeers() behaviour prior to consensus switchover, to reduce the number of variables.
2022-06-16 18:38:27 +01:00
CalDescent
5ed1ec8809
Merge remote-tracking branch 'catbref/sync-long-tip' into sync-long-tip
2022-06-16 18:35:16 +01:00
catbref
431cbf01af
BlockMinter will discard block candidates that turn out to be invalid just prior to adding transactions, to be potentially reminted in the next pass
2022-06-16 17:47:08 +01:00
CalDescent
af792dfc06
Updated AdvancedInstaller project for v3.3.5
2022-06-15 21:11:12 +01:00
CalDescent
d3b6c5f052
Bump version to 3.3.5
2022-06-14 23:18:46 +01:00
CalDescent
f48eb27f00
Revert "Temporarily limit block minter as first stage of multipart minting fix. This will be reverted almost immediately after release."
...
This reverts commit 0eebfe4a8c
2022-06-14 22:42:44 +01:00
CalDescent
b02ac2561f
Revert "Safety check - also to be removed shortly."
...
This reverts commit 8b3f9db497
2022-06-14 22:42:38 +01:00
CalDescent
1b2f66b201
Bump version to 3.3.4
2022-06-13 23:40:39 +01:00
CalDescent
e992f6b683
Increase column size to allow for approx 10x as many online accounts in each block.
2022-06-13 22:51:48 +01:00
CalDescent
8b3f9db497
Safety check - also to be removed shortly.
2022-06-13 22:41:10 +01:00
CalDescent
0eebfe4a8c
Temporarily limit block minter as first stage of multipart minting fix. This will be reverted almost immediately after release.
2022-06-13 22:40:54 +01:00
CalDescent
12b3fc257b
Updated AdvancedInstaller project for v3.3.3
2022-06-04 19:50:43 +01:00
CalDescent
66a3322ea6
Bump version to 3.3.3
2022-06-04 19:16:01 +01:00
CalDescent
4965cb7121
Set BlockV2Message min peer version to 3.3.3
2022-06-04 15:50:17 +01:00
